Don't derive GVK for generic List type

grantr · grantr · commit bf4afaa21bb6 · 2018-11-15T10:24:42.000-08:00
metav1.List and corev1.List don't conform to the TypeList standard
expected by getGVKFromList.
diff --git a/pkg/client/fake/client.go b/pkg/client/fake/client.go
@@ -169,6 +169,10 @@ func getGVKFromList(list runtime.Object, scheme *runtime.Scheme) (schema.GroupVe
 		return schema.GroupVersionKind{}, err
 	}
 
+	if gvk.Kind == "List" {
+		return schema.GroupVersionKind{}, fmt.Errorf("cannot derive GVK for generic List type %T (kind %q)", list, gvk)
+	}
+
 	if !strings.HasSuffix(gvk.Kind, "List") {
 		return schema.GroupVersionKind{}, fmt.Errorf("non-list type %T (kind %q) passed as output", list, gvk)
 	}

Original file line number	Diff line number	Diff line change
`@@ -169,6 +169,10 @@ func getGVKFromList(list runtime.Object, scheme *runtime.Scheme) (schema.GroupVe`
`169`	`169`	`return schema.GroupVersionKind{}, err`
`170`	`170`	`}`
`171`	`171`
	`172`	`+ if gvk.Kind == "List" {`
	`173`	`+ return schema.GroupVersionKind{}, fmt.Errorf("cannot derive GVK for generic List type %T (kind %q)", list, gvk)`
	`174`	`+ }`
	`175`	`+`
`172`	`176`	`if !strings.HasSuffix(gvk.Kind, "List") {`
`173`	`177`	`return schema.GroupVersionKind{}, fmt.Errorf("non-list type %T (kind %q) passed as output", list, gvk)`
`174`	`178`	`}`