Skip to content

Commit e8a1781

Browse files
committed
ext/standard: Transform tentative return types into proper types for Directory class
This class is now final
1 parent 0640fba commit e8a1781

File tree

3 files changed

+8
-11
lines changed

3 files changed

+8
-11
lines changed

ext/standard/dir.stub.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,19 +99,16 @@ final class Directory
9999
public readonly mixed $handle;
100100

101101
/**
102-
* @tentative-return-type
103102
* @implementation-alias closedir
104103
*/
105104
public function close(): void {}
106105

107106
/**
108-
* @tentative-return-type
109107
* @implementation-alias rewinddir
110108
*/
111109
public function rewind(): void {}
112110

113111
/**
114-
* @tentative-return-type
115112
* @implementation-alias readdir
116113
*/
117114
public function read(): string|false {}

ext/standard/dir_arginfo.h

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ext/standard/tests/directory/DirectoryClass_reflection_structure.phpt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ $rc = new ReflectionClass("Directory");
1212
echo $rc;
1313

1414
?>
15-
--EXPECTF--
15+
--EXPECT--
1616
Structure of Directory class:
17-
Class [ <internal%s> final class Directory ] {
17+
Class [ <internal:standard> final class Directory ] {
1818

1919
- Constants [0] {
2020
}
@@ -35,21 +35,21 @@ Class [ <internal%s> final class Directory ] {
3535

3636
- Parameters [0] {
3737
}
38-
- Tentative return [ void ]
38+
- Return [ void ]
3939
}
4040

4141
Method [ <internal:standard> public method rewind ] {
4242

4343
- Parameters [0] {
4444
}
45-
- Tentative return [ void ]
45+
- Return [ void ]
4646
}
4747

4848
Method [ <internal:standard> public method read ] {
4949

5050
- Parameters [0] {
5151
}
52-
- Tentative return [ string|false ]
52+
- Return [ string|false ]
5353
}
5454
}
5555
}

0 commit comments

Comments
 (0)