Skip to content

Commit 00e7ee5

Browse files
committed
Fix request payloads to use key/value pair params but unwrap it on ClickToLoadMessagingTransport to match sendMessage() messages format
1 parent 83f2d71 commit 00e7ee5

File tree

2 files changed

+23
-8
lines changed

2 files changed

+23
-8
lines changed

src/features/click-to-load.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -631,7 +631,7 @@ function createPlaceholderElementAndReplace (widget, trackingElement) {
631631

632632
// YouTube
633633
if (widget.replaceSettings.type === 'youtube-video') {
634-
ctl.messaging.notify('updateYouTubeCTLAddedFlag', true)
634+
ctl.messaging.notify('updateYouTubeCTLAddedFlag', { youTubeCTLAddedFlag: true })
635635
replaceYouTubeCTL(trackingElement, widget)
636636

637637
// Subscribe to changes to youtubePreviewsEnabled setting
@@ -692,7 +692,7 @@ function replaceYouTubeCTL (trackingElement, widget) {
692692
dataKey: 'yt-preview-toggle', // data-key attribute for button
693693
label: widget.replaceSettings.previewToggleText, // Text to be presented with toggle
694694
size: isMobileApp ? 'lg' : 'md',
695-
onClick: () => ctl.messaging.notify('setYoutubePreviewsEnabled', true) // Toggle click callback
695+
onClick: () => ctl.messaging.notify('setYoutubePreviewsEnabled', { youtubePreviewsEnabled: true }) // Toggle click callback
696696
},
697697
withFeedback: {
698698
label: sharedStrings.shareFeedback,
@@ -1540,7 +1540,7 @@ function createYouTubeBlockingDialog (trackingElement, widget) {
15401540
)
15411541
previewToggle.addEventListener(
15421542
'click',
1543-
() => makeModal(widget.entity, () => ctl.messaging.notify('setYoutubePreviewsEnabled', true), widget.entity)
1543+
() => makeModal(widget.entity, () => ctl.messaging.notify('setYoutubePreviewsEnabled', { youtubePreviewsEnabled: true }), widget.entity)
15441544
)
15451545
bottomRow.appendChild(previewToggle)
15461546

@@ -1657,7 +1657,7 @@ function createYouTubePreview (originalElement, widget) {
16571657
)
16581658
previewToggle.addEventListener(
16591659
'click',
1660-
() => ctl.messaging.notify('setYoutubePreviewsEnabled', false)
1660+
() => ctl.messaging.notify('setYoutubePreviewsEnabled', { youtubePreviewsEnabled: false })
16611661
)
16621662

16631663
/** Preview Info Text */

src/features/click-to-load/ctl-messaging-transport.js

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,18 +58,33 @@ export class ClickToLoadMessagingTransport {
5858
}
5959
let params = req.params
6060

61-
// Adapts request for getYouTubeVideoDetails by identifying the correct
61+
switch (req.method) {
62+
// Adapts request for 'getYouTubeVideoDetails' by identifying the correct
6263
// response for each request and updating params to expect current
6364
// implementation specifications.
64-
if (req.method === 'getYouTubeVideoDetails') {
65+
case 'getYouTubeVideoDetails': {
6566
comparator = (eventData) => {
6667
return (
6768
eventData.responseMessageType === req.method &&
68-
eventData.response &&
69-
eventData.response.videoURL === req.params?.videoURL
69+
eventData.response &&
70+
eventData.response.videoURL === req.params?.videoURL
7071
)
7172
}
7273
params = req.params.videoURL
74+
break
75+
}
76+
// Unwrap 'updateYouTubeCTLAddedFlag' params to match expected payload
77+
// for sendMessage()
78+
case 'updateYouTubeCTLAddedFlag': {
79+
params = req.params.youTubeCTLAddedFlag
80+
break
81+
}
82+
// Unwrap 'setYoutubePreviewsEnabled' params to match expected payload
83+
// for sendMessage()
84+
case 'setYoutubePreviewsEnabled': {
85+
params = req.params.youtubePreviewsEnabled
86+
break
87+
}
7388
}
7489

7590
sendMessage(req.method, params)

0 commit comments

Comments
 (0)