injected: fixing flaky duckplayer tests

Author: shakyShane

injected/integration-test/duckplayer-mobile-drawer.spec.js

@@ -3,7 +3,7 @@ import { DuckplayerOverlays } from './page-objects/duckplayer-overlays.js';
 
 test.describe('Duck Player - Drawer UI variant', () => {
     test.describe('Video Player overlays', () => {
-        test("Selecting 'watch here' on mobile", async ({ page }, workerInfo) => {
+        test("Selecting 'watch here' on mobile abc", async ({ page }, workerInfo) => {
             const overlays = DuckplayerOverlays.create(page, workerInfo);
             await overlays.reducedMotion();
 
@@ -15,6 +15,7 @@ test.describe('Duck Player - Drawer UI variant', () => {
             await overlays.gotoPlayerPage();
 
             // watch here = overlays removed
+            await overlays.mobile.drawerIsPresented();
             await overlays.mobile.choosesWatchHere();
             await overlays.mobile.overlayIsRemoved();
             await overlays.pixels.sendsPixels([
@@ -34,6 +35,7 @@ test.describe('Duck Player - Drawer UI variant', () => {
             await overlays.gotoPlayerPage();
 
             // watch here = overlays removed
+            await overlays.mobile.drawerIsPresented();
             await overlays.mobile.selectsRemember();
             await overlays.mobile.choosesWatchHere();
             await overlays.mobile.overlayIsRemoved();
@@ -54,6 +56,7 @@ test.describe('Duck Player - Drawer UI variant', () => {
             await overlays.userSettingIs('always ask');
             await overlays.gotoPlayerPage();
 
+            await overlays.mobile.drawerIsPresented();
             await overlays.mobile.choosesDuckPlayer();
             await overlays.pixels.sendsPixels([
                 { pixelName: 'overlay', params: {} },
@@ -72,6 +75,7 @@ test.describe('Duck Player - Drawer UI variant', () => {
             await overlays.userSettingIs('always ask');
             await overlays.gotoPlayerPage();
 
+            await overlays.mobile.drawerIsPresented();
             await overlays.mobile.selectsRemember();
             await overlays.mobile.choosesDuckPlayer();
             await overlays.pixels.sendsPixels([

injected/integration-test/page-objects/duckplayer-overlays.js

@@ -542,6 +542,10 @@ class DuckplayerOverlaysMobile {
         this.overlays = overlays;
     }
 
+    async drawerIsPresented() {
+        const { page } = this.overlays;
+        await page.locator('ddg-video-drawer-mobile').waitFor({ state: 'visible', timeout: 2000 });
+    }
     async choosesWatchHere() {
         const { page } = this.overlays;
         await page.getByRole('button', { name: 'No Thanks' }).click();