Windows \r sad

Author: jonathanKingston

.github/workflows/tests.yml

@@ -1,6 +1,10 @@
 name: Test
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+    - main
+  pull_request:
 
 jobs:
   unit:

scripts/check-for-changes.sh

@@ -1,2 +1,3 @@
-git update-index --refresh 
+git update-index --refresh
+git diff-index --patch-with-raw HEAD --
 git diff-index --quiet HEAD --

scripts/generateOverloadSnapshots.js

@@ -11,6 +11,11 @@ const configPath = join(ROOT, '../unit-test/script-overload-snapshots/config')
  * These are used in unit-test/script-overload.js and ran automatically in automation so that we verify the output is correct.
  */
 function generateOut () {
+    if (process.platform === 'win32') {
+        console.log('skipping test generation on windows')
+        return
+    }
+
     const files = readdirSync(configPath)
     for (const fileName of files) {
         const config = readFileSync(join(configPath, fileName)).toString()

unit-test/script-overload.js

@@ -6,6 +6,10 @@ import { cwd } from '../scripts/script-utils.js'
 const ROOT = join(cwd(import.meta.url))
 const configPath = join(ROOT, '/script-overload-snapshots/config')
 
+function replaceWindowsLineEndings (text) {
+    return text.replace(/\r/gm, '')
+}
+
 describe('Output validation', () => {
     it('Given the correct config we should generate expected code output', () => {
         // Uses the snapshots generated in scripts/generateOverloadSnapshots.js to ensure we don't break the output.
@@ -15,7 +19,7 @@ describe('Output validation', () => {
             const out = wrapScriptCodeOverload('console.log(1)', JSON.parse(config))
             const outName = fileName.replace(/.json$/, '.js')
             const expectedOut = readFileSync(join(ROOT, '/script-overload-snapshots/out/', outName)).toString()
-            expect(out).withContext(`wrapScriptCodeOverload with ${fileName} matches ${outName}`).toEqual(expectedOut)
+            expect(replaceWindowsLineEndings(out)).withContext(`wrapScriptCodeOverload with ${fileName} matches ${outName}`).toEqual(replaceWindowsLineEndings(expectedOut))
         }
     })
 })