Fix contentScopeFeatures TypeScript linting errors in inject scripts (#289)

Author: kzar

inject/android.js

@@ -8,11 +8,11 @@ function init () {
     if (isGloballyDisabled(processedConfig)) {
         return
     }
-    // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
+
     contentScopeFeatures.load({
         platform: processedConfig.platform
     })
-    // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
+
     contentScopeFeatures.init(processedConfig)
 
     // Not supported:

inject/apple.js

@@ -8,11 +8,11 @@ function init () {
     if (isGloballyDisabled(processedConfig)) {
         return
     }
-    // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
+
     contentScopeFeatures.load({
         platform: processedConfig.platform
     })
-    // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
+
     contentScopeFeatures.init(processedConfig)
 
     // Not supported:

inject/chrome-mv3.js

@@ -4,7 +4,6 @@ import { isTrackerOrigin } from '../src/trackers'
 
 const secret = (crypto.getRandomValues(new Uint32Array(1))[0] / 2 ** 32).toString().replace('0.', '')
 
-// @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
 contentScopeFeatures.load({
     platform: {
         name: 'extension'
@@ -21,13 +20,11 @@ window.addEventListener(secret, ({ detail: message }) => {
 
     switch (message.type) {
     case 'update':
-        // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
         contentScopeFeatures.update(message)
         break
     case 'register':
         if (message.argumentsObject) {
             message.argumentsObject.messageSecret = secret
-            // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
             contentScopeFeatures.init(message.argumentsObject)
         }
         break

inject/integration.js

@@ -70,7 +70,7 @@ function mergeDeep (target, ...sources) {
 async function init () {
     const topLevelUrl = getTopLevelURL()
     const processedConfig = generateConfig()
-    // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
+
     await contentScopeFeatures.load({
         platform: processedConfig.platform
     })
@@ -79,7 +79,6 @@ async function init () {
     setStatus('loaded')
 
     if (!topLevelUrl.searchParams.has('wait-for-init-args')) {
-        // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
         await contentScopeFeatures.init(processedConfig)
         setStatus('initialized')
         return
@@ -90,7 +89,6 @@ async function init () {
         // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
         const merged = mergeDeep(processedConfig, evt.detail)
         // init features
-        // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
         await contentScopeFeatures.init(merged)
 
         // set status to initialized so that tests can resume

inject/mozilla.js

@@ -17,7 +17,6 @@ function randomString () {
 }
 
 function init () {
-    // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
     contentScopeFeatures.load({
         platform: {
             name: 'extension'
@@ -50,14 +49,12 @@ function init () {
             })
         }
         message.messageSecret = messageSecret
-        // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
         contentScopeFeatures.init(message)
     })
 
     chrome.runtime.onMessage.addListener((message) => {
         // forward update messages to the embedded script
         if (message && message.type === 'update') {
-            // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
             contentScopeFeatures.update(message)
         }
     })
@@ -71,7 +68,6 @@ function init () {
         // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
         chrome.runtime.sendMessage(m && m.detail, response => {
             const msg = { func: messageType, response }
-            // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
             contentScopeFeatures.update({ detail: msg })
         })
     })

inject/windows.js

@@ -8,12 +8,11 @@ function init () {
     if (isGloballyDisabled(processedConfig)) {
         return
     }
-    // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
+
     contentScopeFeatures.load({
         platform: processedConfig.platform
     })
 
-    // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
     contentScopeFeatures.init(processedConfig)
 
     // Not supported:

src/globals.d.ts

@@ -3,3 +3,8 @@ declare function exportFunction(fn: Function, desc: object, out: object): void;
 declare function exportFunction(fn: Function, desc: object): void;
 declare function cloneInto(fn: object, desc: object, out: object): void;
 declare function cloneInto(fn: object, desc: object): void;
+declare namespace contentScopeFeatures {
+    function init(args: Object): void;
+    function load(args: Object): void;
+    function update(args: Object): void;
+}