Skip to content

Commit 345139b

Browse files
author
Shane Osbourne
committed
fix html strings includes
1 parent 59942ec commit 345139b

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

integration-test/playwright/page-objects/duckplayer-overlays.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,9 @@ export class DuckplayerOverlays {
5858
async overlayBlocksVideo () {
5959
await this.page.locator('ddg-video-overlay').waitFor({ state: 'visible', timeout: 1000 })
6060
await this.page.getByRole('link', { name: 'Watch in Duck Player' }).waitFor({ state: 'visible', timeout: 1000 })
61+
await this.page
62+
.getByText('Duck Player provides a clean viewing experience without personalized ads and prevents viewing activity from influencing your YouTube recommendations.')
63+
.waitFor({ timeout: 100 })
6164
}
6265

6366
async smallOverlayShows () {

src/features/duckplayer/components/ddg-video-overlay.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@ export class DDGVideoOverlay extends HTMLElement {
6161
<div class="ddg-vpo-content">
6262
<div class="ddg-eyeball">${svgIcon}</div>
6363
<div class="ddg-vpo-title">${i18n.t('videoOverlayTitle')}</div>
64-
<div class="ddg-vpo-text">${i18n.t('videoOverlaySubtitle')}</div>
64+
<div class="ddg-vpo-text">
65+
<b>${i18n.t('playText')}</b> ${i18n.t('videoOverlaySubtitle')}
66+
</div>
6567
<div class="ddg-vpo-buttons">
6668
<button class="ddg-vpo-button ddg-vpo-cancel" type="button">${i18n.t('videoButtonOptOut')}</button>
6769
<a class="ddg-vpo-button ddg-vpo-open" href="#">${i18n.t('videoButtonOpen')}</a>

src/features/duckplayer/text.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const text = {
99
title: 'Tired of targeted YouTube ads and recommendations?'
1010
},
1111
videoOverlaySubtitle: {
12-
title: '<b>Duck Player</b> provides a clean viewing experience without personalized ads and prevents viewing activity from influencing your YouTube recommendations.'
12+
title: 'provides a clean viewing experience without personalized ads and prevents viewing activity from influencing your YouTube recommendations.'
1313
},
1414
videoButtonOpen: {
1515
title: 'Watch in Duck Player'

0 commit comments

Comments
 (0)