added debugging

Author: shakyShane

packages/messaging/lib/windows.js

@@ -73,8 +73,17 @@ export class WindowsMessagingTransport {
     return new Promise((resolve, reject) => {
       try {
         subscribe(this.config, comparator, opts, (value, unsubscribe) => {
-          resolve(value)
-          unsubscribe()
+          unsubscribe();
+          if ('result' in value) {
+            resolve(value['result']);
+          } else {
+            if ('error' in value) {
+              reject(new Error(value.error.message || 'unknown error'))
+            } else {
+              console.warn('unknown response', value);
+              reject(new Error('unknown response'))
+            }
+          }
         })
       } catch (e) {
         reject(e)
@@ -91,7 +100,11 @@ export class WindowsMessagingTransport {
           && eventData.context === msg.context
           && eventData.subscriptionName === msg.subscriptionName
     }
-    return subscribe(this.config, comparator, {}, callback)
+    const cb = (eventData) => {
+      if ('params' in eventData) return callback(eventData['params']);
+      console.warn("debug: params field missing in subscription event", eventData)
+    }
+    return subscribe(this.config, comparator, {}, cb)
   }
 }
 
@@ -174,7 +187,7 @@ function subscribe(config, comparator, options, callback) {
     }
     if (comparator(event.data)) {
       if (!teardown) throw new Error('unreachable')
-      callback(event.data.params, teardown)
+      callback(event.data, teardown)
     }
   }
 

packages/special-pages/pages/duckplayer/src/js/messages.js

@@ -20,7 +20,7 @@ export class DuckPlayerPageMessages {
      * @param {UserValues} userValues
      */
     setUserValues (userValues) {
-        this.messaging.notify('setUserValues', userValues)
+        return this.messaging.request('setUserValues', userValues)
     }
 
     /**