never apply view-transitions if the background is a user-image

Author: shakyShane

special-pages/pages/new-tab/app/favorites/components/Favorites.js

@@ -46,8 +46,6 @@ export const FavoritesThemeContext = createContext({
  */
 export function Favorites({ gridRef, favorites, expansion, toggle, openContextMenu, openFavorite, add, canAnimateItems }) {
     const { t } = useTypedTranslationWith(/** @type {import('../strings.json')} */ ({}));
-    const platformName = usePlatformName();
-
     // see: https://www.w3.org/WAI/ARIA/apg/patterns/accordion/examples/accordion/
     const WIDGET_ID = useId();
     const TOGGLE_ID = useId();
@@ -60,12 +58,10 @@ export function Favorites({ gridRef, favorites, expansion, toggle, openContextMe
     const kind = useComputed(() => data.value.background.kind);
 
     // A flag to determine if animations are available. This is needed
-    // because in webkit applying 'view-transition' css properties causes an odd experience
+    // because 'view-transition' CSS properties causes an odd experience
     // with filters.
     const animateItems = useComputed(() => {
-        if (platformName === 'windows' && canAnimateItems) return true;
-        if (platformName === 'macos' && canAnimateItems && kind.value !== 'userImage') return true;
-        return false;
+        return canAnimateItems && kind.value !== 'userImage';
     });
 
     return (

special-pages/pages/new-tab/app/favorites/components/FavoritesCustomized.js

@@ -19,7 +19,6 @@ import { usePlatformName } from '../../settings.provider.js';
 export function FavoritesConsumer() {
     const { state, toggle, favoritesDidReOrder, openContextMenu, openFavorite, add } = useContext(FavoritesContext);
     const telemetry = useTelemetry();
-    const platformName = usePlatformName();
     const { data: backgroundData } = useContext(CustomizerContext);
 
     /**
@@ -29,12 +28,7 @@ export function FavoritesConsumer() {
      */
     function didReorder(data) {
         const background = backgroundData.value.background;
-        let supportsViewTransitions = false;
-
-        if (state.config?.animation?.kind === 'view-transitions') {
-            if (platformName === 'windows') supportsViewTransitions = true;
-            if (platformName === 'macos' && background.kind !== 'userImage') supportsViewTransitions = true;
-        }
+        const supportsViewTransitions = state.config?.animation?.kind === 'view-transitions' && background.kind !== 'userImage';
 
         if (supportsViewTransitions) {
             viewTransition(() => {