Skip to content

Commit 657c6a5

Browse files
committed
stable scrollbars
1 parent a24832c commit 657c6a5

File tree

3 files changed

+19
-19
lines changed

3 files changed

+19
-19
lines changed

special-pages/pages/history/app/components/App.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@ import { useSearchCommitForRange } from '../global/hooks/useSearchCommitForRange
1717
import { useURLReflection } from '../global/hooks/useURLReflection.js';
1818
import { useSearchCommit } from '../global/hooks/useSearchCommit.js';
1919
import { useRangesData } from '../global/Providers/HistoryServiceProvider.js';
20+
import { usePlatformName } from '../types.js';
2021

2122
export function App() {
23+
const platformName = usePlatformName();
2224
const mainRef = useRef(/** @type {HTMLElement|null} */ (null));
2325
const { isDarkMode } = useEnv();
2426
const ranges = useRangesData();
@@ -58,7 +60,7 @@ export function App() {
5860
}, [onKeyDown, query]);
5961

6062
return (
61-
<div class={styles.layout} data-theme={isDarkMode ? 'dark' : 'light'}>
63+
<div class={styles.layout} data-theme={isDarkMode ? 'dark' : 'light'} data-platform={platformName}>
6264
<aside class={styles.aside}>
6365
<Sidebar ranges={ranges} />
6466
</aside>

special-pages/pages/history/app/components/App.module.css

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,13 @@ body {
1010
}
1111

1212
.layout {
13+
--sidebar-width: 250px;
14+
--main-padding-left: 48px;
15+
--main-padding-right: 76px;
16+
--windows-scrollbar: 15px;
17+
1318
display: grid;
14-
grid-template-columns: 250px 1fr;
19+
grid-template-columns: var(--sidebar-width) 1fr;
1520
grid-template-rows: max-content 1fr;
1621
grid-template-areas:
1722
'aside header'
@@ -22,8 +27,8 @@ body {
2227
}
2328
.header {
2429
grid-area: header;
25-
padding-left: 48px;
26-
padding-right: 76px;
30+
padding-left: var(--main-padding-left);
31+
padding-right: var(--main-padding-right);
2732
}
2833
.search {
2934
justify-self: flex-end;
@@ -36,24 +41,17 @@ body {
3641
.main {
3742
grid-area: main;
3843
overflow: auto;
39-
padding-left: 48px;
40-
padding-right: 76px;
44+
padding-left: var(--main-padding-left);
45+
padding-right: var(--main-padding-right);
4146
padding-top: 24px;
4247
}
43-
4448
.customScroller {
4549
overflow-y: scroll;
46-
&::-webkit-scrollbar {
47-
width: 12px;
48-
}
49-
50-
&::-webkit-scrollbar-track {
51-
border-radius: 6px;
52-
}
50+
scrollbar-gutter: stable;
51+
}
5352

54-
&::-webkit-scrollbar-thumb {
55-
background: rgb(108, 108, 108);
56-
border: 4px solid var(--history-background-color);
57-
border-radius: 6px;
53+
[data-platform="windows"] {
54+
.customScroller {
55+
padding-right: calc(var(--main-padding-right) - var(--windows-scrollbar));
5856
}
5957
}

special-pages/pages/history/src/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export class HistoryPage {
5656
}
5757
}
5858

59-
const baseEnvironment = new Environment().withInjectName(document.documentElement.dataset.platform).withEnv(import.meta.env);
59+
const baseEnvironment = new Environment().withInjectName(import.meta.injectName).withEnv(import.meta.env);
6060

6161
const messaging = createSpecialPageMessaging({
6262
injectName: baseEnvironment.injectName,

0 commit comments

Comments
 (0)