Skip to content

Commit 8c70987

Browse files
committed
Update Click to Load YouTube (preview-enabled) footer text
During internal review, it was requested that we change the footer-text for Click to Load YouTube placeholders.
1 parent c1999e6 commit 8c70987

27 files changed

+38
-29
lines changed

src/features/click-to-load.js

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1473,9 +1473,18 @@ function createYouTubePreview (originalElement, widget) {
14731473
/** Preview Info Text */
14741474
const previewText = document.createElement('div')
14751475
previewText.style.cssText = styles.contentText + styles.toggleButtonText + styles.youTubePreviewInfoText
1476-
previewText.innerText = widget.replaceSettings.placeholder.previewInfoText + ' '
1477-
// Use darkMode styles because of preview background
1478-
previewText.appendChild(getLearnMoreLink('darkMode'))
1476+
// Since this string contains an anchor element, setting innerText won't
1477+
// work.
1478+
// Warning: This is not ideal! The translated (and original) strings must be
1479+
// checked very carefully! Any HTML they contain will be inserted.
1480+
// Ideally, the translation system would allow only certain element
1481+
// types to be included, and would avoid the URLs for links being
1482+
// included in the translations.
1483+
previewText.insertAdjacentHTML(
1484+
'beforeend', widget.replaceSettings.placeholder.previewInfoText
1485+
)
1486+
previewText.querySelector('a').style.cssText =
1487+
styles.generalLink + styles.darkMode.linkFont
14791488

14801489
previewToggleRow.appendChild(previewToggle)
14811490
previewToggleRow.appendChild(previewText)

src/locales/click-to-load/bg/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/cs/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/da/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/de/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/el/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/en/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/es/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/et/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/fi/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/fr/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/hr/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/hu/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/it/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/lt/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/lv/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/nb/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/nl/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/pl/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/pt/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/ro/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/ru/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/sk/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/sl/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/sv/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/click-to-load/tr/youtube.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

unit-test/verify-artifacts.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { cwd } from '../scripts/script-utils.js'
66
const ROOT = join(cwd(import.meta.url), '..')
77
const BUILD = join(ROOT, 'build')
88
const APPLE_BUILD = join(ROOT, 'Sources/ContentScopeScripts/dist')
9-
const CSS_OUTPUT_SIZE = 551000
9+
const CSS_OUTPUT_SIZE = 560000
1010
const CSS_OUTPUT_SIZE_CHROME = CSS_OUTPUT_SIZE * 1.45 // 45% larger for Chrome MV2 due to base64 encoding
1111

1212
const checks = {

0 commit comments

Comments
 (0)