Add overriding the prototype back the cases where the page has overloaded us (#301)

Author: jonathanKingston

integration-test/test-runtime-checks.js

@@ -224,7 +224,6 @@ describe('Runtime checks: should allow element modification', () => {
                 }
             }
         })
-        // And now with a script that will execute
         const scriptResult4 = await page.evaluate(
             () => {
                 function getAttributeValues (el) {
@@ -295,4 +294,34 @@ describe('Runtime checks: should allow element modification', () => {
             nodeAndFakeNodeMatch: false
         })
     })
+
+    it('Script that should filter props and attributes', async () => {
+        const port = server.address().port
+        const page = await browser.newPage()
+        await gotoAndWait(page, `http://localhost:${port}/blank.html`, {
+            site: {
+                enabledFeatures: ['runtimeChecks']
+            },
+            featureSettings: {
+                runtimeChecks: {
+                    taintCheck: 'enabled',
+                    matchAllDomains: 'enabled',
+                    matchAllStackDomains: 'enabled',
+                    overloadInstanceOf: 'enabled'
+                }
+            }
+        })
+        const scriptResult5 = await page.evaluate(
+            () => {
+                // @ts-expect-error Undefined property for testing
+                window.scripty5Ran = false
+                const myScript = document.createElement('script')
+                myScript.innerText = 'window.scripty5Ran = true'
+                Object.setPrototypeOf(myScript, HTMLScriptElement.prototype)
+                document.body.appendChild(myScript)
+                // @ts-expect-error Undefined property for testing
+                return window.scripty5Ran
+            })
+        expect(scriptResult5).toBe(true)
+    })
 })

src/features/runtime-checks.js

@@ -45,6 +45,10 @@ class DDGRuntimeChecks extends HTMLElement {
         // Solves re-entrancy issues from React
         if (this.#connected) return
         this.#connected = true
+        if (!this.transplantElement) {
+            // Restore the 'this' object with the DDGRuntimeChecks prototype as sometimes pages will overwrite it.
+            Object.setPrototypeOf(this, DDGRuntimeChecks.prototype)
+        }
         this.transplantElement()
     }