Disable more permissions for Windows app (#297)

Some permissions are disabled in Windows app using DevTools protocol, however sometimes setting those permissions can result in a crash which is a transient error. To make the app more stable we added hardening to the DevTools protocol calls and disable these specific permissions in Web API as well in case those calls fail.

https://app.asana.com/0/1201424400691338/1204114339745362/f

Author: q71114

src/features/windows-permission-usage.js

@@ -372,25 +372,43 @@ export function init () {
     // these permissions cannot be disabled using WebView2 or DevTools protocol
     const permissionsToDisable = [
         // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
-        { name: 'Bluetooth', prototype: Bluetooth.prototype, method: 'requestDevice' },
+        { name: 'Bluetooth', prototype: Bluetooth.prototype, method: 'requestDevice', isPromise: true },
         // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
-        { name: 'USB', prototype: USB.prototype, method: 'requestDevice' },
+        { name: 'USB', prototype: USB.prototype, method: 'requestDevice', isPromise: true },
         // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
-        { name: 'Serial', prototype: Serial.prototype, method: 'requestPort' },
+        { name: 'Serial', prototype: Serial.prototype, method: 'requestPort', isPromise: true },
         // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
-        { name: 'HID', prototype: HID.prototype, method: 'requestDevice' },
-        { name: 'Protocol handler', prototype: Navigator.prototype, method: 'registerProtocolHandler' }
+        { name: 'HID', prototype: HID.prototype, method: 'requestDevice', isPromise: true },
+        { name: 'Protocol handler', prototype: Navigator.prototype, method: 'registerProtocolHandler', isPromise: false },
+        { name: 'MIDI', prototype: Navigator.prototype, method: 'requestMIDIAccess', isPromise: true }
     ]
-    for (const { name, prototype, method } of permissionsToDisable) {
+    for (const { name, prototype, method, isPromise } of permissionsToDisable) {
         try {
             const proxy = new DDGProxy(featureName, prototype, method, {
                 apply () {
-                    return Promise.reject(new DOMException('Permission denied'))
+                    if (isPromise) {
+                        return Promise.reject(new DOMException('Permission denied'))
+                    } else {
+                        throw new DOMException('Permission denied')
+                    }
                 }
             })
             proxy.overload()
         } catch (error) {
             console.info(`Could not disable access to ${name} because of error`, error)
         }
     }
+
+    // these permissions can be disabled using DevTools protocol but it's not reliable and can throw exception sometimes
+    const permissionsToDelete = [
+        { name: 'Idle detection', permission: 'IdleDetector' },
+        { name: 'NFC', permission: 'NDEFReader' },
+        { name: 'Orientation', permission: 'ondeviceorientation' },
+        { name: 'Motion', permission: 'ondevicemotion' }
+    ]
+    for (const { permission } of permissionsToDelete) {
+        if (permission in window) {
+            delete window[permission]
+        }
+    }
 }