Fix Facebook Click to Load logins and add related JSDoc comment (#226)

There was a typo in one of the calls to `enableSocialTracker` which
caused Facebook requests to not be allowed properly when the user
clicked to login via Facebook. That in turn broke the "Log in via
Facebook" functionality.

Let's fix that typo, but also add a JSDoc comment to make the function
easier to use correctly in the future.

Author: kzar

Sources/ContentScopeScripts/dist/contentScope.js

@@ -3538,12 +3538,32 @@
   /*********************************************************
    *  Messaging to surrogates & extension
    *********************************************************/
+
+  /**
+   * @typedef enableSocialTrackerRequest
+   * @property {string} entity
+   *   The entity to unblock requests for (e.g. "Facebook").
+   * @property {bool} [isLogin=false]
+   *   True if we should "allow social login", defaults to false.
+   * @property {string} action
+   *   The Click to Load blocklist rule action (e.g. "block-ctl-fb") that should
+   *   be allowed. Important since in the future there might be multiple types of
+   *   embedded content from the same entity that the user can allow
+   *   independently.
+   */
+
+  /**
+   * Send a message to the background to unblock requests for the given entity for
+   * the page.
+   * @param {enableSocialTrackerRequest} message
+   * @see {@event ddg-ctp-enableSocialTracker-complete} for the response handler.
+   */
   function enableSocialTracker (message) {
       sendMessage('enableSocialTracker', message);
   }
 
   function runLogin (entity) {
-      enableSocialTracker(entity);
+      enableSocialTracker({ entity, isLogin: true });
       originalWindowDispatchEvent(
           createCustomEvent('ddg-ctp-run-login', {
               detail: {

build/android/contentScope.js

@@ -1583,12 +1583,32 @@ async function replaceClickToLoadElements (config, targetElement) {
 /*********************************************************
  *  Messaging to surrogates & extension
  *********************************************************/
+
+/**
+ * @typedef enableSocialTrackerRequest
+ * @property {string} entity
+ *   The entity to unblock requests for (e.g. "Facebook").
+ * @property {bool} [isLogin=false]
+ *   True if we should "allow social login", defaults to false.
+ * @property {string} action
+ *   The Click to Load blocklist rule action (e.g. "block-ctl-fb") that should
+ *   be allowed. Important since in the future there might be multiple types of
+ *   embedded content from the same entity that the user can allow
+ *   independently.
+ */
+
+/**
+ * Send a message to the background to unblock requests for the given entity for
+ * the page.
+ * @param {enableSocialTrackerRequest} message
+ * @see {@event ddg-ctp-enableSocialTracker-complete} for the response handler.
+ */
 function enableSocialTracker (message) {
     sendMessage('enableSocialTracker', message)
 }
 
 function runLogin (entity) {
-    enableSocialTracker(entity, true)
+    enableSocialTracker({ entity, isLogin: true })
     originalWindowDispatchEvent(
         createCustomEvent('ddg-ctp-run-login', {
             detail: {