Merge 6898a1c into 627b5e4

Author: mgurgel

injected/integration-test/duckplayer-mobile-drawer.spec.js

@@ -94,7 +94,7 @@ test.describe('Duck Player - Drawer UI variant', () => {
             await overlays.mobile.clicksOnVideoThumbnail();
             await overlays.pixels.sendsPixels([
                 { pixelName: 'overlay', params: {} },
-                { pixelName: 'play.do_not_use.thumbnail', params: {} },
+                { pixelName: 'play.do_not_use.dismiss', params: {} },
             ]);
             await overlays.userSettingWasNotUpdated();
         });
@@ -112,7 +112,7 @@ test.describe('Duck Player - Drawer UI variant', () => {
             await overlays.mobile.clicksOnDrawerBackdrop();
             await overlays.pixels.sendsPixels([
                 { pixelName: 'overlay', params: {} },
-                { pixelName: 'play.do_not_use', params: {} },
+                { pixelName: 'play.do_not_use.dismiss', params: {} },
             ]);
             await overlays.userSettingWasNotUpdated();
         });

injected/src/features/duckplayer/overlay-messages.js

@@ -157,7 +157,7 @@ export class Pixel {
      *   | {name: "play.use", remember: "0" | "1"}
      *   | {name: "play.use.thumbnail"}
      *   | {name: "play.do_not_use", remember: "0" | "1"}
-     *   | {name: "play.do_not_use.thumbnail"}} input
+     *   | {name: "play.do_not_use.dismiss"}} input
      */
     constructor(input) {
         this.input = input;
@@ -177,7 +177,7 @@ export class Pixel {
             case 'play.do_not_use': {
                 return { remember: this.input.remember };
             }
-            case 'play.do_not_use.thumbnail':
+            case 'play.do_not_use.dismiss':
                 return {};
             default:
                 throw new Error('unreachable');

injected/src/features/duckplayer/video-overlay.js

@@ -292,10 +292,10 @@ export class VideoOverlay {
                     return this.mobileOptOut(e.detail.remember).catch(console.error);
                 });
                 drawer.addEventListener(DDGVideoDrawerMobile.DISMISS, () => {
-                    return this.mobileOptOut(false).catch(console.error); // Dismissal should not persist user's choice. Ignore remember-me value.
+                    return this.dismissOverlay();
                 });
                 drawer.addEventListener(DDGVideoDrawerMobile.THUMBNAIL_CLICK, () => {
-                    return this.videoThumbnailClick();
+                    return this.dismissOverlay();
                 });
                 drawer.addEventListener(DDGVideoDrawerMobile.OPT_IN, (/** @type {CustomEvent<{remember: boolean}>} */ e) => {
                     return this.mobileOptIn(e.detail.remember, params).catch(console.error);
@@ -508,8 +508,8 @@ export class VideoOverlay {
         this.destroy();
     }
 
-    videoThumbnailClick() {
-        const pixel = new Pixel({ name: 'play.do_not_use.thumbnail' });
+    dismissOverlay() {
+        const pixel = new Pixel({ name: 'play.do_not_use.dismiss' });
         this.messages.sendPixel(pixel);
 
         return this.destroy();