Move assetConfig to ContentFeature class

Author: sammacbeth

src/content-feature.js

@@ -2,6 +2,12 @@ import { camelcase, matchHostname, processAttr } from './utils.js'
 import { immutableJSONPatch } from 'immutable-json-patch'
 import { PerformanceMonitor } from './performance.js'
 
+/**
+ * @typedef {object} AssetConfig
+ * @property {string} regularFontUrl
+ * @property {string} boldFontUrl
+ */
+
 export default class ContentFeature {
     constructor (featureName) {
         this.name = featureName
@@ -21,6 +27,13 @@ export default class ContentFeature {
         return this._platform
     }
 
+    /**
+     * @type {AssetConfig}
+     */
+    get assetConfig () {
+        return this._args?.assets || {}
+    }
+
     /**
      * Get the value of a config setting.
      * If the value is not set, return the default value.

src/features/click-to-load.js

@@ -22,7 +22,7 @@ const titleID = 'DuckDuckGoPrivacyEssentialsCTLElementTitle'
 // @see {getConfig}
 let config = null
 let sharedStrings = null
-let styles = getStyles()
+let styles = null
 
 // TODO: Remove these redundant data structures and refactor the related code.
 //       There should be no need to have the entity configuration stored in two
@@ -894,10 +894,10 @@ function makeBaseStyleElement (mode = 'lightMode') {
  * Creates an anchor element with no destination. It is expected that a click
  * handler is added to the element later.
  * @param {string} linkText
- * @param {displayMode} [mode='lightMode']
+ * @param {displayMode} mode
  * @returns {HTMLAnchorElement}
  */
-function makeTextButton (linkText, mode) {
+function makeTextButton (linkText, mode = 'lightMode') {
     const linkElement = document.createElement('a')
     linkElement.style.cssText = styles.headerLink + styles[mode].linkFont
     linkElement.textContent = linkText
@@ -1617,9 +1617,7 @@ export default class ClickToLoad extends ContentFeature {
         config = localizedConfig.config
         sharedStrings = localizedConfig.sharedStrings
         // update styles if asset config was sent
-        if (args?.assets) {
-            styles = getStyles(args.assets)
-        }
+        styles = getStyles(this.assetConfig)
 
         for (const entity of Object.keys(config)) {
             // Strip config entities that are first-party, or aren't enabled in the

src/features/click-to-load/ctl-config.js

@@ -7,16 +7,10 @@ import localesJSON from '../../../build/locales/ctl-locales.js'
 /*********************************************************
  *  Style Definitions
  *********************************************************/
-/**
- * @typedef {object} AssetConfig
- * @property {string} regularFontUrl
- * @property {string} boldFontUrl
- */
-
 /**
  * Get CSS style defintions for CTL, using the provided AssetConfig for any non-embedded assets
  * (e.g. fonts.)
- * @param {AssetConfig} [assets]
+ * @param {import('../../content-feature.js').AssetConfig} [assets]
  */
 export function getStyles (assets) {
     let fontStyle = ''