Skip to content

Commit d3f8379

Browse files
committed
added favicon rounding
1 parent 6c57d1c commit d3f8379

File tree

6 files changed

+17
-3
lines changed

6 files changed

+17
-3
lines changed

special-pages/pages/history/app/mocks/history.mocks.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ export const historyMocks = {
1919
url: 'https://www.youtube.com/watch?v=75Mw8r5gW8E',
2020
domain: 'www.youtube.com',
2121
etldPlusOne: 'youtube.com',
22+
favicon: {
23+
src: './company-icons/fake.svg',
24+
maxAvailableSize: 32,
25+
},
2226
},
2327
{
2428
id: 'history-id-02',

special-pages/pages/history/integration-tests/history-selections.spec.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,5 +178,4 @@ test.describe('history selections', () => {
178178
await hp.selectsRowIndexWithShift(2);
179179
await hp.deletesWithKeyboard(hp.ids(3), { action: 'delete' });
180180
});
181-
test.skip('resets underlying state when elements are removed', () => {});
182181
});
Lines changed: 9 additions & 0 deletions
Loading

special-pages/shared/components/FaviconWithState.module.css

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
.favicon {
2+
--border-radius: 8px;
3+
24
display: block;
35
background-repeat: no-repeat;
46
background-size: contain;
57
pointer-events: none;
8+
border-radius: var(--border-radius);
69
}
710

811
.faviconLarge {
@@ -13,6 +16,7 @@
1316
.faviconSmall {
1417
max-height: calc(16 * var(--px-in-rem));
1518
max-width: calc(16 * var(--px-in-rem));
19+
--border-radius: 4px;
1620
}
1721

1822
.faviconText {
@@ -23,7 +27,6 @@
2327
color: white;
2428
font-size: 1.1rem;
2529
font-weight: 600;
26-
border-radius: 8px;
2730
height: calc(32 * var(--px-in-rem));
2831
width: calc(32 * var(--px-in-rem));
2932

@@ -33,7 +36,6 @@
3336

3437
&.faviconSmall {
3538
font-size: 0.5rem;
36-
border-radius: 4px;
3739
height: calc(16 * var(--px-in-rem));
3840
width: calc(16 * var(--px-in-rem));
3941
}

0 commit comments

Comments
 (0)