open in windows-specific page for now

Author: Shane Osbourne

packages/special-pages/pages/duckplayer/src/js/index.js

@@ -324,14 +324,18 @@ const Comms = {
      * To mock, use:
      *
      * `window.postMessage({ alwaysOpenSetting: false })`
+     *
+     * @param {object} opts
+     * @param {ImportMeta['env']} opts.env
+     * @param {ImportMeta['platform']} opts.platform
      */
-    init: () => {
+    init: (opts) => {
         const messageContext = new MessagingContext({
             context: 'specialPages',
             featureName: 'duckPlayerPage',
-            env: import.meta.env
+            env: opts.env
         })
-        if (import.meta.platform === 'windows') {
+        if (opts.platform === 'windows') {
             const opts = new WindowsMessagingConfig({
                 methods: {
                     // @ts-expect-error - not in @types/chrome
@@ -344,7 +348,7 @@ const Comms = {
             })
             const messaging = new Messaging(messageContext, opts)
             Comms.messaging = new DuckPlayerPageMessages(messaging)
-        } else if (import.meta.platform === 'integration') {
+        } else if (opts.platform === 'integration') {
             const config = new TestTransportConfig({
                 notify (msg) {
                     console.log(msg)
@@ -541,34 +545,28 @@ const PlayOnYouTube = {
         return document.querySelector('.play-on-youtube')
     },
 
-    /**
-     * Returns the full YouTube source URL for a video, based on video id
-     * @param {string} videoId
-     * @param {number|boolean} timestamp
-     * @returns {string}
-     */
-    getVideoLinkURL: (videoId, timestamp) => {
-        const url = new URL('/watch', 'https://www.youtube.com')
-
-        url.searchParams.set('v', videoId)
-
-        if (timestamp) {
-            url.searchParams.set('t', timestamp + 's')
-        }
-
-        return url.href
-    },
-
     /**
      * If there is a valid video id, set the 'href' of the YouTube button to the
      * video link url
+     *
+     * @param {object} opts
+     * @param {string} opts.base
      */
-    init: () => {
+    init: (opts) => {
         const validVideoId = Comms.getValidVideoId()
         const timestamp = Comms.getSanitizedTimestamp()
+        console.log({ validVideoId })
 
         if (validVideoId) {
-            PlayOnYouTube.button().setAttribute('href', PlayOnYouTube.getVideoLinkURL(validVideoId, timestamp))
+            const url = new URL(opts.base)
+
+            url.searchParams.set('v', validVideoId)
+
+            if (timestamp) {
+                url.searchParams.set('t', timestamp + 's')
+            }
+
+            PlayOnYouTube.button().setAttribute('href', url.href)
         }
     }
 }
@@ -753,9 +751,15 @@ const MouseMove = {
  */
 document.addEventListener('DOMContentLoaded', () => {
     Setting.init()
-    Comms.init()
+    Comms.init({
+        platform: import.meta.platform,
+        env: import.meta.env
+    })
     VideoPlayer.init()
     Tooltip.init()
-    PlayOnYouTube.init()
+    PlayOnYouTube.init({
+        // todo(Shane): platform specific
+        base: 'duck://player/openInYoutube'
+    })
     MouseMove.init()
 })

packages/special-pages/tests/duckplayer.spec.js

@@ -66,8 +66,7 @@ test.describe('duckplayer toolbar', () => {
         const duckplayer = DuckPlayerPage.create(page, workerInfo)
         await duckplayer.openWithVideoID()
         await duckplayer.hasLoadedIframe()
-        await duckplayer.clickPlayOnYouTube()
-        await duckplayer.navigatedToYouTube()
+        await duckplayer.opensInYoutube()
     })
 })
 

packages/special-pages/tests/page-objects/duck-player.js

@@ -155,14 +155,16 @@ export class DuckPlayerPage {
         expect(await failure).toEqual('duck://settings/duckplayer')
     }
 
-    async clickPlayOnYouTube () {
-        await this.page.getByText('Watch on YouTube').click()
-    }
-
-    async navigatedToYouTube (videoID = MOCK_VIDEO_ID) {
-        const youtubeSrc = new URL('https://www.youtube.com/watch')
-        youtubeSrc.searchParams.set('v', videoID)
-        await expect(this.page).toHaveURL(youtubeSrc.toString())
+    async opensInYoutube () {
+        // duck:// scheme will fail, but we can assert that it was tried and grab the URL
+        const failure = new Promise(resolve => {
+            this.page.context().on('requestfailed', f => {
+                resolve(f.url())
+            })
+        })
+        await this.page.getByRole('link', { name: 'Watch on YouTube' }).click()
+        // todo(Shane): platform specific
+        expect(await failure).toEqual('duck://player/openInYoutube?v=VIDEO_ID')
     }
 
     /**