Cleanup

Author: mgurgel

special-pages/pages/duckplayer/app/settings.js

@@ -5,7 +5,7 @@ const DEFAULT_SIGN_IN_REQURED_HREF = '[href*="//support.google.com/youtube/answe
  * @property {'enabled'|'disabled'} state
  * @property {object} [settings]
  * @property {string} [settings.signInRequiredSelector]
-*/
+ */
 
 export class Settings {
     /**
@@ -51,8 +51,8 @@ export class Settings {
      * @return {CustomErrorSettings}
      */
     parseLegacyCustomError(customErrorSettings) {
-        if (!customErrorSettings || customErrorSettings.state !== 'enabled') {
-            return { state: 'disabled'};
+        if (customErrorSettings?.state !== 'enabled') {
+            return { state: 'disabled' };
         }
 
         const { settings, signInRequiredSelector } = customErrorSettings;
@@ -61,8 +61,8 @@ export class Settings {
             state: 'enabled',
             settings: {
                 ...settings,
-                ...(signInRequiredSelector && { signInRequiredSelector })
-            }
+                ...(signInRequiredSelector && { signInRequiredSelector }),
+            },
         };
     }
 

special-pages/pages/duckplayer/unit-tests/settings.mjs

@@ -6,11 +6,11 @@ describe('parses settings', () => {
     it('handles disabled custom error schema', () => {
         const settings = new Settings({
             customError: {
-                state: 'disabled'
-            }
+                state: 'disabled',
+            },
         });
         const expected = {
-            state: 'disabled'
+            state: 'disabled',
         };
 
         deepEqual(settings.customError, expected);
@@ -19,14 +19,14 @@ describe('parses settings', () => {
         const settings = new Settings({
             customError: {
                 state: 'enabled',
-                signInRequiredSelector: 'div'
-            }
+                signInRequiredSelector: 'div',
+            },
         });
         const expected = {
             state: 'enabled',
             settings: {
-                signInRequiredSelector: 'div'
-            }
+                signInRequiredSelector: 'div',
+            },
         };
 
         deepEqual(settings.customError, expected);
@@ -36,28 +36,28 @@ describe('parses settings', () => {
             customError: {
                 state: 'enabled',
                 settings: {
-                    signInRequiredSelector: 'div'
-                }
-            }
+                    signInRequiredSelector: 'div',
+                },
+            },
         });
         const expected = {
             state: 'enabled',
             settings: {
-                signInRequiredSelector: 'div'
-            }
+                signInRequiredSelector: 'div',
+            },
         };
 
         deepEqual(settings.customError, expected);
     });
     it('handles custom error enabled without settings', () => {
         const settings = new Settings({
             customError: {
-                state: 'enabled'
-            }
+                state: 'enabled',
+            },
         });
         const expected = {
             state: 'enabled',
-            settings: {}
+            settings: {},
         };
 
         deepEqual(settings.customError, expected);
@@ -66,11 +66,11 @@ describe('parses settings', () => {
         const settings = new Settings({
             customError: {
                 // @ts-expect-error - Malformed object on purpose
-                status: 'enabled'
-            }
+                status: 'enabled',
+            },
         });
         const expected = {
-            state: 'disabled'
+            state: 'disabled',
         };
 
         deepEqual(settings.customError, expected);