Skip to content

history: add 'source' for each query #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Mar 5, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209561829858104

Description

  • adding a source flag to every query - this allows the native side to understand if it's the initial query or a user-triggered one.

Testing Steps

  • The integration tests cover all the use-cases and can be reviewed there. Everything on the FE should operate the same.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Mar 5, 2025

Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit e7d9ab2
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67c84977fa0d280008002b74
😎 Deploy Preview https://deploy-preview-1543--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 5, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 5, 2025

[Beta] Generated file diff

Time updated: Wed, 05 Mar 2025 12:55:22 GMT

Integration
    - integration/pages/history/dist/index.js

File has changed

Windows
    - windows/pages/history/dist/index.js

File has changed

Apple
    - dist/pages/history/dist/index.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review March 5, 2025 11:05
@shakyShane shakyShane requested review from mgurgel and a team as code owners March 5, 2025 11:05
@shakyShane shakyShane mentioned this pull request Mar 5, 2025
9 tasks
Copy link

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢 🇮🇹

@shakyShane shakyShane merged commit 59fcdfe into main Mar 5, 2025
13 checks passed
@shakyShane shakyShane deleted the 03-05-history_add_source_for_each_query branch March 5, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants