Skip to content

Fix TrustedScript type for script content #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Fix TrustedScript type for script content #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/features/runtime-checks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* global TrustedScriptURL */
/* global TrustedScriptURL, TrustedScript */

import { DDGProxy, getStackTraceOrigins, getStack, matchHostname, getFeatureSetting, getFeatureSettingEnabled, injectGlobalStyles, createStyleElement, processAttr } from '../utils.js'

Expand Down Expand Up @@ -116,8 +116,8 @@ class DDGRuntimeChecks extends HTMLElement {
// Short circuit if we don't have any script text
if (el.textContent === '') return
// Short circuit if we're in a trusted script environment
// @ts-expect-error TrustedScriptURL is not defined in the TS lib
if (supportedTrustedTypes && el.textContent instanceof TrustedScriptURL) return
// @ts-expect-error TrustedScript is not defined in the TS lib
if (supportedTrustedTypes && el.textContent instanceof TrustedScript) return

const config = scriptOverload
const processedConfig = {}
Expand Down