Skip to content

Ignore monitoring for DOM0 event listeners as they're already handled #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Ignore monitoring for DOM0 event listeners as they're already handled #364

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ce8dbb
Ignore monitoring for DOM0 event listeners as they're already handled
jonathanKingston Mar 30, 2023
0b018c4
Add option to remotely configure monitoring
jonathanKingston Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/features/runtime-checks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ let initialCreateElement
let tagModifiers = {}
let shadowDomEnabled = false
let scriptOverload = {}
// Ignore monitoring properties that are only relevant once and already handled
const defaultIgnoreMonitorList = ['onerror', 'onload']
let ignoreMonitorList = defaultIgnoreMonitorList

/**
* @param {string} tagName
Expand Down Expand Up @@ -106,6 +109,7 @@ class DDGRuntimeChecks extends HTMLElement {
},
set (value) {
if (shouldFilterKey(this.#tagName, 'property', prop)) return
if (ignoreMonitorList.includes(prop)) return
el[prop] = value
}
})
Expand Down Expand Up @@ -468,6 +472,7 @@ export default class RuntimeChecks extends ContentFeature {
tagModifiers = this.getFeatureSetting('tagModifiers') || {}
shadowDomEnabled = this.getFeatureSettingEnabled('shadowDom') || false
scriptOverload = this.getFeatureSetting('scriptOverload') || {}
ignoreMonitorList = this.getFeatureSetting('ignoreMonitorList') || defaultIgnoreMonitorList

overrideCreateElement()

Expand Down