Mark appropriate friends for Activator related classes

At the moment the friends are marked by who actually uses the
Activators, but if other uses within embedcdt need access to
Activators of other plug-ins, then those friends should
be declared.

Author: jonahgraham

plugins/org.eclipse.embedcdt.core/META-INF/MANIFEST.MF

@@ -59,7 +59,6 @@ Export-Package: org.eclipse.embedcdt.core,
    org.eclipse.embedcdt.templates.stm,
    org.eclipse.embedcdt.templates.stm.ui,
    org.eclipse.embedcdt.ui",
- org.eclipse.embedcdt.internal.core;x-internal:=true,
  org.eclipse.embedcdt.core.liqp.exceptions;
   x-friends:="org.eclipse.embedcdt,
    org.eclipse.embedcdt.codered,
@@ -461,6 +460,19 @@ Export-Package: org.eclipse.embedcdt.core,
    org.eclipse.embedcdt.templates.stm,
    org.eclipse.embedcdt.templates.stm.ui,
    org.eclipse.embedcdt.ui",
+ org.eclipse.embedcdt.internal.core;
+  x-friends:="org.eclipse.embedcdt.core,
+   org.eclipse.embedcdt.debug.core,
+   org.eclipse.embedcdt.debug.gdbjtag.core,
+   org.eclipse.embedcdt.debug.gdbjtag.jlink.core,
+   org.eclipse.embedcdt.debug.gdbjtag.openocd.core,
+   org.eclipse.embedcdt.debug.gdbjtag.pyocd.core,
+   org.eclipse.embedcdt.debug.gdbjtag.qemu.core,
+   org.eclipse.embedcdt.managedbuild.cross.arm.core,
+   org.eclipse.embedcdt.managedbuild.cross.core,
+   org.eclipse.embedcdt.managedbuild.cross.riscv.core,
+   org.eclipse.embedcdt.packs.core,
+   org.eclipse.embedcdt.templates.core",
  org.json.simple;version="1.1.1";
   x-friends:="org.eclipse.embedcdt.debug.gdbjtag.core,
    org.eclipse.embedcdt,

plugins/org.eclipse.embedcdt.debug.gdbjtag.core/META-INF/MANIFEST.MF

@@ -30,7 +30,7 @@ Export-Package: org.eclipse.embedcdt.debug.gdbjtag.core,
  org.eclipse.embedcdt.debug.gdbjtag.core.properties,
  org.eclipse.embedcdt.debug.gdbjtag.core.services,
  org.eclipse.embedcdt.debug.gdbjtag.core.viewmodel.peripheral,
- org.eclipse.embedcdt.internal.debug.gdbjtag.core;x-internal:=true
+ org.eclipse.embedcdt.internal.debug.gdbjtag.core;x-friends:="org.eclipse.embedcdt.debug.gdbjtag.ui"
 Import-Package: org.eclipse.embedcdt.packs.core.data.xcdl,
  org.eclipse.jface.preference
 Automatic-Module-Name: org.eclipse.embedcdt.debug.gdbjtag.core

plugins/org.eclipse.embedcdt.debug.gdbjtag.jlink.core/META-INF/MANIFEST.MF

@@ -21,5 +21,5 @@ Bundle-Localization: plugin
 Export-Package: org.eclipse.embedcdt.debug.gdbjtag.jlink.core,
  org.eclipse.embedcdt.debug.gdbjtag.jlink.core.dsf,
  org.eclipse.embedcdt.debug.gdbjtag.jlink.core.preferences,
- org.eclipse.embedcdt.internal.debug.gdbjtag.jlink.core;x-internal:=true
+ org.eclipse.embedcdt.internal.debug.gdbjtag.jlink.core;x-friends:="org.eclipse.embedcdt.debug.gdbjtag.jlink.ui"
 Automatic-Module-Name: org.eclipse.embedcdt.debug.gdbjtag.jlink.core

plugins/org.eclipse.embedcdt.debug.gdbjtag.openocd.core/META-INF/MANIFEST.MF

@@ -21,5 +21,5 @@ Bundle-Localization: plugin
 Export-Package: org.eclipse.embedcdt.debug.gdbjtag.openocd.core,
  org.eclipse.embedcdt.debug.gdbjtag.openocd.core.dsf,
  org.eclipse.embedcdt.debug.gdbjtag.openocd.core.preferences,
- org.eclipse.embedcdt.internal.debug.gdbjtag.openocd.core;x-internal:=true
+ org.eclipse.embedcdt.internal.debug.gdbjtag.openocd.core;x-friends:="org.eclipse.embedcdt.debug.gdbjtag.openocd.ui"
 Automatic-Module-Name: org.eclipse.embedcdt.debug.gdbjtag.openocd.core

plugins/org.eclipse.embedcdt.debug.gdbjtag.pyocd.core/META-INF/MANIFEST.MF

@@ -21,5 +21,5 @@ Bundle-Localization: plugin
 Export-Package: org.eclipse.embedcdt.debug.gdbjtag.pyocd.core,
  org.eclipse.embedcdt.debug.gdbjtag.pyocd.core.dsf,
  org.eclipse.embedcdt.debug.gdbjtag.pyocd.core.preferences,
- org.eclipse.embedcdt.internal.debug.gdbjtag.pyocd.core;x-internal:=true
+ org.eclipse.embedcdt.internal.debug.gdbjtag.pyocd.core;x-friends:="org.eclipse.embedcdt.debug.gdbjtag.pyocd.ui"
 Automatic-Module-Name: org.eclipse.embedcdt.debug.gdbjtag.pyocd.core

plugins/org.eclipse.embedcdt.debug.gdbjtag.qemu.core/META-INF/MANIFEST.MF

@@ -20,5 +20,5 @@ Bundle-Localization: plugin
 Export-Package: org.eclipse.embedcdt.debug.gdbjtag.qemu.core,
  org.eclipse.embedcdt.debug.gdbjtag.qemu.core.dsf,
  org.eclipse.embedcdt.debug.gdbjtag.qemu.core.preferences,
- org.eclipse.embedcdt.internal.debug.gdbjtag.qemu.core;x-internal:=true
+ org.eclipse.embedcdt.internal.debug.gdbjtag.qemu.core;x-friends:="org.eclipse.embedcdt.debug.gdbjtag.qemu.ui"
 Automatic-Module-Name: org.eclipse.embedcdt.debug.gdbjtag.qemu.core

plugins/org.eclipse.embedcdt.managedbuild.cross.arm.core/META-INF/MANIFEST.MF

@@ -15,7 +15,7 @@ Bundle-ActivationPolicy: lazy
 Bundle-RequiredExecutionEnvironment: JavaSE-11
 Bundle-Vendor: %bundle.vendor
 Bundle-Localization: plugin
-Export-Package: org.eclipse.embedcdt.internal.managedbuild.cross.arm.core;x-internal:=true,
+Export-Package: org.eclipse.embedcdt.internal.managedbuild.cross.arm.core;x-friends:="org.eclipse.embedcdt.managedbuild.cross.arm.ui",
  org.eclipse.embedcdt.managedbuild.cross.arm.core,
  org.eclipse.embedcdt.managedbuild.cross.arm.core.preferences
 Automatic-Module-Name: org.eclipse.embedcdt.managedbuild.cross.arm.core

plugins/org.eclipse.embedcdt.managedbuild.cross.core/META-INF/MANIFEST.MF

@@ -16,7 +16,7 @@ Bundle-ActivationPolicy: lazy
 Bundle-RequiredExecutionEnvironment: JavaSE-11
 Bundle-Vendor: %bundle.vendor
 Bundle-Localization: plugin
-Export-Package: org.eclipse.embedcdt.internal.managedbuild.cross.core;x-internal:=true,
+Export-Package: org.eclipse.embedcdt.internal.managedbuild.cross.core;x-friends:="org.eclipse.embedcdt.managedbuild.cross.ui,org.eclipse.embedcdt.managedbuild.cross.arm.core,org.eclipse.embedcdt.managedbuild.cross.riscv.core",
  org.eclipse.embedcdt.managedbuild.cross.core,
  org.eclipse.embedcdt.managedbuild.cross.core.preferences,
  org.eclipse.embedcdt.managedbuild.cross.core.xpi

plugins/org.eclipse.embedcdt.managedbuild.cross.riscv.core/META-INF/MANIFEST.MF

@@ -18,7 +18,7 @@ Bundle-ActivationPolicy: lazy
 Bundle-RequiredExecutionEnvironment: JavaSE-11
 Bundle-Vendor: %bundle.vendor
 Bundle-Localization: plugin
-Export-Package: org.eclipse.embedcdt.internal.managedbuild.cross.riscv.core;x-internal:=true,
+Export-Package: org.eclipse.embedcdt.internal.managedbuild.cross.riscv.core;x-friends:="org.eclipse.embedcdt.managedbuild.cross.riscv.ui",
  org.eclipse.embedcdt.managedbuild.cross.riscv.core,
  org.eclipse.embedcdt.managedbuild.cross.riscv.core.preferences
 Automatic-Module-Name: org.eclipse.embedcdt.managedbuild.cross.riscv.core

plugins/org.eclipse.embedcdt.packs.core/META-INF/MANIFEST.MF

@@ -8,7 +8,7 @@ Bundle-RequiredExecutionEnvironment: JavaSE-11
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %bundle.vendor
 Bundle-Localization: plugin
-Export-Package: org.eclipse.embedcdt.internal.packs.core;x-internal:=true,
+Export-Package: org.eclipse.embedcdt.internal.packs.core;x-friends:="org.eclipse.embedcdt.debug.gdbjtag.core,org.eclipse.embedcdt.packs.ui",
  org.eclipse.embedcdt.packs.core,
  org.eclipse.embedcdt.packs.core.data,
  org.eclipse.embedcdt.packs.core.data.cmsis,

plugins/org.eclipse.embedcdt.ui/META-INF/MANIFEST.MF

@@ -8,7 +8,26 @@ Bundle-RequiredExecutionEnvironment: JavaSE-11
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %bundle.vendor
 Bundle-Localization: plugin
-Export-Package: org.eclipse.embedcdt.internal.ui;x-internal:=true,
+Export-Package: org.eclipse.embedcdt.internal.ui;
+  x-friends:="org.eclipse.embedcdt.codered.ui,
+   org.eclipse.embedcdt.debug.gdbjtag.jlink.ui,
+   org.eclipse.embedcdt.debug.gdbjtag.openocd.ui,
+   org.eclipse.embedcdt.debug.gdbjtag.pyocd.ui,
+   org.eclipse.embedcdt.debug.gdbjtag.qemu.ui,
+   org.eclipse.embedcdt.debug.gdbjtag.restart.ui,
+   org.eclipse.embedcdt.debug.gdbjtag.ui,
+   org.eclipse.embedcdt.managedbuild.cross.arm.ui,
+   org.eclipse.embedcdt.managedbuild.cross.riscv.ui,
+   org.eclipse.embedcdt.managedbuild.cross.ui,
+   org.eclipse.embedcdt.managedbuild.packs.ui,
+   org.eclipse.embedcdt.packs.ui,
+   org.eclipse.embedcdt.templates.ad.ui,
+   org.eclipse.embedcdt.templates.cortexm.ui,
+   org.eclipse.embedcdt.templates.freescale.pe.ui,
+   org.eclipse.embedcdt.templates.freescale.ui,
+   org.eclipse.embedcdt.templates.sifive.ui,
+   org.eclipse.embedcdt.templates.stm.ui,
+   org.eclipse.embedcdt.ui",
  org.eclipse.embedcdt.internal.ui.preferences;x-internal:=true,
  org.eclipse.embedcdt.internal.ui.properties;x-internal:=true,
  org.eclipse.embedcdt.ui,