Export all packages and mark all internal packages as such

x-internal is used for packages not used elsewhere in embedcdt.
x-friends for those used elsewhere in embedcdt (x-friends means
internal, except to the list of bundles)

x-internal applied to all packages with internal in the name.

It may be worth adding x-internal to additional packages if we
don't want to support them as API. It is not necessary to rename
a package, simply marking it x-internal is sufficient.

Author: jonahgraham

plugins/org.eclipse.embedcdt.codered.ui/META-INF/MANIFEST.MF

@@ -20,3 +20,6 @@ Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %bundle.vendor
 Bundle-Localization: plugin
 Automatic-Module-Name: org.eclipse.embedcdt.codered.ui
+Export-Package: org.eclipse.embedcdt.codered.ui,
+ org.eclipse.embedcdt.internal.codered.ui;x-internal:=true,
+ org.eclipse.embedcdt.internal.codered.ui.perspectives;x-internal:=true

plugins/org.eclipse.embedcdt.debug.gdbjtag.jlink.ui/META-INF/MANIFEST.MF

@@ -23,6 +23,9 @@ Bundle-RequiredExecutionEnvironment: JavaSE-11
 Bundle-Vendor: %bundle.vendor
 Bundle-ActivationPolicy: lazy
 Bundle-Localization: plugin
-Export-Package: org.eclipse.embedcdt.debug.gdbjtag.jlink.ui
+Export-Package: org.eclipse.embedcdt.debug.gdbjtag.jlink.ui,
+ org.eclipse.embedcdt.internal.debug.gdbjtag.jlink.ui;x-internal:=true,
+ org.eclipse.embedcdt.internal.debug.gdbjtag.jlink.ui.preferences;x-internal:=true,
+ org.eclipse.embedcdt.internal.debug.gdbjtag.jlink.ui.properties;x-internal:=true
 Bundle-Activator: org.eclipse.embedcdt.debug.gdbjtag.jlink.ui.Activator
 Automatic-Module-Name: org.eclipse.embedcdt.debug.gdbjtag.jlink.ui

plugins/org.eclipse.embedcdt.debug.gdbjtag.openocd.ui/META-INF/MANIFEST.MF

@@ -23,6 +23,9 @@ Bundle-RequiredExecutionEnvironment: JavaSE-11
 Bundle-Vendor: %bundle.vendor
 Bundle-ActivationPolicy: lazy
 Bundle-Localization: plugin
-Export-Package: org.eclipse.embedcdt.debug.gdbjtag.openocd.ui
+Export-Package: org.eclipse.embedcdt.debug.gdbjtag.openocd.ui,
+ org.eclipse.embedcdt.internal.debug.gdbjtag.openocd.ui;x-internal:=true,
+ org.eclipse.embedcdt.internal.debug.gdbjtag.openocd.ui.preferences;x-internal:=true,
+ org.eclipse.embedcdt.internal.debug.gdbjtag.openocd.ui.properties;x-internal:=true
 Bundle-Activator: org.eclipse.embedcdt.debug.gdbjtag.openocd.ui.Activator
 Automatic-Module-Name: org.eclipse.embedcdt.debug.gdbjtag.openocd.ui

plugins/org.eclipse.embedcdt.debug.gdbjtag.pyocd.ui/META-INF/MANIFEST.MF

@@ -23,6 +23,9 @@ Bundle-RequiredExecutionEnvironment: JavaSE-11
 Bundle-Vendor: %bundle.vendor
 Bundle-ActivationPolicy: lazy
 Bundle-Localization: plugin
-Export-Package: org.eclipse.embedcdt.debug.gdbjtag.pyocd.ui
+Export-Package: org.eclipse.embedcdt.debug.gdbjtag.pyocd.ui,
+ org.eclipse.embedcdt.internal.debug.gdbjtag.pyocd.ui;x-internal:=true,
+ org.eclipse.embedcdt.internal.debug.gdbjtag.pyocd.ui.preferences;x-internal:=true,
+ org.eclipse.embedcdt.internal.debug.gdbjtag.pyocd.ui.properties;x-internal:=true
 Bundle-Activator: org.eclipse.embedcdt.debug.gdbjtag.pyocd.ui.Activator
 Automatic-Module-Name: org.eclipse.embedcdt.debug.gdbjtag.pyocd.ui

plugins/org.eclipse.embedcdt.debug.gdbjtag.qemu.ui/META-INF/MANIFEST.MF

@@ -23,6 +23,9 @@ Bundle-RequiredExecutionEnvironment: JavaSE-11
 Bundle-Vendor: %bundle.vendor
 Bundle-ActivationPolicy: lazy
 Bundle-Localization: plugin
-Export-Package: org.eclipse.embedcdt.debug.gdbjtag.qemu.ui
+Export-Package: org.eclipse.embedcdt.debug.gdbjtag.qemu.ui,
+ org.eclipse.embedcdt.internal.debug.gdbjtag.qemu.ui;x-internal:=true,
+ org.eclipse.embedcdt.internal.debug.gdbjtag.qemu.ui.preferences;x-internal:=true,
+ org.eclipse.embedcdt.internal.debug.gdbjtag.qemu.ui.properties;x-internal:=true
 Bundle-Activator: org.eclipse.embedcdt.debug.gdbjtag.qemu.ui.Activator
 Automatic-Module-Name: org.eclipse.embedcdt.debug.gdbjtag.qemu.ui

plugins/org.eclipse.embedcdt.debug.gdbjtag.restart.ui/META-INF/MANIFEST.MF

@@ -19,3 +19,5 @@ Require-Bundle: org.eclipse.embedcdt.core;bundle-version="6.0.0",
 Bundle-ActivationPolicy: lazy
 Bundle-Activator: org.eclipse.embedcdt.debug.gdbjtag.restart.ui.Activator
 Automatic-Module-Name: org.eclipse.embedcdt.debug.gdbjtag.restart.ui
+Export-Package: org.eclipse.embedcdt.debug.gdbjtag.restart.ui,
+ org.eclipse.embedcdt.debug.gdbjtag.restart.ui.action

plugins/org.eclipse.embedcdt.debug.gdbjtag.ui/META-INF/MANIFEST.MF

@@ -35,5 +35,14 @@ Bundle-Vendor: %bundle.vendor
 Bundle-ActivationPolicy: lazy
 Bundle-Localization: plugin
 Export-Package: org.eclipse.embedcdt.debug.gdbjtag.ui,
- org.eclipse.embedcdt.debug.gdbjtag.ui.preferences
+ org.eclipse.embedcdt.debug.gdbjtag.ui.preferences,
+ org.eclipse.embedcdt.debug.gdbjtag.ui.properties,
+ org.eclipse.embedcdt.debug.gdbjtag.ui.render.peripheral,
+ org.eclipse.embedcdt.debug.gdbjtag.ui.render.peripherals,
+ org.eclipse.embedcdt.debug.gdbjtag.ui.viewmodel,
+ org.eclipse.embedcdt.debug.gdbjtag.ui.viewmodel.peripherals,
+ org.eclipse.embedcdt.internal.debug.gdbjtag.ui;x-internal:=true,
+ org.eclipse.embedcdt.internal.debug.gdbjtag.ui.preferences;x-internal:=true,
+ org.eclipse.embedcdt.internal.debug.gdbjtag.ui.render.peripheral;x-internal:=true,
+ org.eclipse.embedcdt.internal.debug.gdbjtag.ui.render.peripherals;x-internal:=true
 Automatic-Module-Name: org.eclipse.embedcdt.debug.gdbjtag.ui

plugins/org.eclipse.embedcdt.managedbuild.cross.arm.ui/META-INF/MANIFEST.MF

@@ -20,6 +20,10 @@ Bundle-ActivationPolicy: lazy
 Bundle-RequiredExecutionEnvironment: JavaSE-11
 Bundle-Vendor: %bundle.vendor
 Bundle-Localization: plugin
-Export-Package: org.eclipse.embedcdt.managedbuild.cross.arm.ui
+Export-Package: org.eclipse.embedcdt.internal.managedbuild.cross.arm.ui;x-internal:=true,
+ org.eclipse.embedcdt.internal.managedbuild.cross.arm.ui.preferences;x-internal:=true,
+ org.eclipse.embedcdt.internal.managedbuild.cross.arm.ui.properties;x-internal:=true,
+ org.eclipse.embedcdt.managedbuild.cross.arm.ui,
+ org.eclipse.embedcdt.managedbuild.cross.arm.ui.preferences
 Bundle-Activator: org.eclipse.embedcdt.managedbuild.cross.arm.ui.Activator
 Automatic-Module-Name: org.eclipse.embedcdt.managedbuild.cross.arm.ui

plugins/org.eclipse.embedcdt.managedbuild.cross.riscv.ui/META-INF/MANIFEST.MF

@@ -20,7 +20,9 @@ Bundle-ActivationPolicy: lazy
 Bundle-RequiredExecutionEnvironment: JavaSE-11
 Bundle-Vendor: %bundle.vendor
 Bundle-Localization: plugin
-Export-Package: org.eclipse.embedcdt.internal.managedbuild.cross.riscv.ui.properties,
+Export-Package: org.eclipse.embedcdt.internal.managedbuild.cross.riscv.ui;x-internal:=true,
+ org.eclipse.embedcdt.internal.managedbuild.cross.riscv.ui.preferences;x-internal:=true,
+ org.eclipse.embedcdt.internal.managedbuild.cross.riscv.ui.properties;x-internal:=true,
  org.eclipse.embedcdt.managedbuild.cross.riscv.ui,
  org.eclipse.embedcdt.managedbuild.cross.riscv.ui.preferences
 Bundle-Activator: org.eclipse.embedcdt.managedbuild.cross.riscv.ui.Activator

plugins/org.eclipse.embedcdt.managedbuild.cross.ui/META-INF/MANIFEST.MF

@@ -25,6 +25,106 @@ Bundle-ActivationPolicy: lazy
 Bundle-RequiredExecutionEnvironment: JavaSE-11
 Bundle-Vendor: %bundle.vendor
 Bundle-Localization: plugin
-Export-Package: org.eclipse.embedcdt.internal.managedbuild.cross.ui.preferences,
- org.eclipse.embedcdt.internal.managedbuild.cross.ui.properties
 Automatic-Module-Name: org.eclipse.embedcdt.managedbuild.cross.ui
+Export-Package: org.eclipse.embedcdt.internal.managedbuild.cross.ui;x-internal:=true,
+ org.eclipse.embedcdt.internal.managedbuild.cross.ui.preferences;
+  x-friends:="org.eclipse.embedcdt,
+   org.eclipse.embedcdt.codered,
+   org.eclipse.embedcdt.codered.ui,
+   org.eclipse.embedcdt.core,
+   org.eclipse.embedcdt.debug.core,
+   org.eclipse.embedcdt.debug.gdbjtag,
+   org.eclipse.embedcdt.debug.gdbjtag.core,
+   org.eclipse.embedcdt.debug.gdbjtag.jlink,
+   org.eclipse.embedcdt.debug.gdbjtag.jlink.core,
+   org.eclipse.embedcdt.debug.gdbjtag.jlink.ui,
+   org.eclipse.embedcdt.debug.gdbjtag.openocd,
+   org.eclipse.embedcdt.debug.gdbjtag.openocd.core,
+   org.eclipse.embedcdt.debug.gdbjtag.openocd.ui,
+   org.eclipse.embedcdt.debug.gdbjtag.pyocd,
+   org.eclipse.embedcdt.debug.gdbjtag.pyocd.core,
+   org.eclipse.embedcdt.debug.gdbjtag.pyocd.ui,
+   org.eclipse.embedcdt.debug.gdbjtag.qemu,
+   org.eclipse.embedcdt.debug.gdbjtag.qemu.core,
+   org.eclipse.embedcdt.debug.gdbjtag.qemu.ui,
+   org.eclipse.embedcdt.debug.gdbjtag.restart.ui,
+   org.eclipse.embedcdt.debug.gdbjtag.ui,
+   org.eclipse.embedcdt.debug.packs,
+   org.eclipse.embedcdt.doc.user,
+   org.eclipse.embedcdt.managedbuild.cross,
+   org.eclipse.embedcdt.managedbuild.cross.arm,
+   org.eclipse.embedcdt.managedbuild.cross.arm.core,
+   org.eclipse.embedcdt.managedbuild.cross.arm.ui,
+   org.eclipse.embedcdt.managedbuild.cross.core,
+   org.eclipse.embedcdt.managedbuild.cross.riscv,
+   org.eclipse.embedcdt.managedbuild.cross.riscv.core,
+   org.eclipse.embedcdt.managedbuild.cross.riscv.ui,
+   org.eclipse.embedcdt.managedbuild.cross.ui,
+   org.eclipse.embedcdt.managedbuild.packs.ui,
+   org.eclipse.embedcdt.packs,
+   org.eclipse.embedcdt.packs.core,
+   org.eclipse.embedcdt.packs.ui,
+   org.eclipse.embedcdt.templates.ad,
+   org.eclipse.embedcdt.templates.ad.ui,
+   org.eclipse.embedcdt.templates.core,
+   org.eclipse.embedcdt.templates.cortexm,
+   org.eclipse.embedcdt.templates.cortexm.ui,
+   org.eclipse.embedcdt.templates.freescale,
+   org.eclipse.embedcdt.templates.freescale.pe.ui,
+   org.eclipse.embedcdt.templates.freescale.ui,
+   org.eclipse.embedcdt.templates.sifive,
+   org.eclipse.embedcdt.templates.sifive.ui,
+   org.eclipse.embedcdt.templates.stm,
+   org.eclipse.embedcdt.templates.stm.ui,
+   org.eclipse.embedcdt.ui",
+ org.eclipse.embedcdt.internal.managedbuild.cross.ui.properties;
+  x-friends:="org.eclipse.embedcdt,
+   org.eclipse.embedcdt.codered,
+   org.eclipse.embedcdt.codered.ui,
+   org.eclipse.embedcdt.core,
+   org.eclipse.embedcdt.debug.core,
+   org.eclipse.embedcdt.debug.gdbjtag,
+   org.eclipse.embedcdt.debug.gdbjtag.core,
+   org.eclipse.embedcdt.debug.gdbjtag.jlink,
+   org.eclipse.embedcdt.debug.gdbjtag.jlink.core,
+   org.eclipse.embedcdt.debug.gdbjtag.jlink.ui,
+   org.eclipse.embedcdt.debug.gdbjtag.openocd,
+   org.eclipse.embedcdt.debug.gdbjtag.openocd.core,
+   org.eclipse.embedcdt.debug.gdbjtag.openocd.ui,
+   org.eclipse.embedcdt.debug.gdbjtag.pyocd,
+   org.eclipse.embedcdt.debug.gdbjtag.pyocd.core,
+   org.eclipse.embedcdt.debug.gdbjtag.pyocd.ui,
+   org.eclipse.embedcdt.debug.gdbjtag.qemu,
+   org.eclipse.embedcdt.debug.gdbjtag.qemu.core,
+   org.eclipse.embedcdt.debug.gdbjtag.qemu.ui,
+   org.eclipse.embedcdt.debug.gdbjtag.restart.ui,
+   org.eclipse.embedcdt.debug.gdbjtag.ui,
+   org.eclipse.embedcdt.debug.packs,
+   org.eclipse.embedcdt.doc.user,
+   org.eclipse.embedcdt.managedbuild.cross,
+   org.eclipse.embedcdt.managedbuild.cross.arm,
+   org.eclipse.embedcdt.managedbuild.cross.arm.core,
+   org.eclipse.embedcdt.managedbuild.cross.arm.ui,
+   org.eclipse.embedcdt.managedbuild.cross.core,
+   org.eclipse.embedcdt.managedbuild.cross.riscv,
+   org.eclipse.embedcdt.managedbuild.cross.riscv.core,
+   org.eclipse.embedcdt.managedbuild.cross.riscv.ui,
+   org.eclipse.embedcdt.managedbuild.cross.ui,
+   org.eclipse.embedcdt.managedbuild.packs.ui,
+   org.eclipse.embedcdt.packs,
+   org.eclipse.embedcdt.packs.core,
+   org.eclipse.embedcdt.packs.ui,
+   org.eclipse.embedcdt.templates.ad,
+   org.eclipse.embedcdt.templates.ad.ui,
+   org.eclipse.embedcdt.templates.core,
+   org.eclipse.embedcdt.templates.cortexm,
+   org.eclipse.embedcdt.templates.cortexm.ui,
+   org.eclipse.embedcdt.templates.freescale,
+   org.eclipse.embedcdt.templates.freescale.pe.ui,
+   org.eclipse.embedcdt.templates.freescale.ui,
+   org.eclipse.embedcdt.templates.sifive,
+   org.eclipse.embedcdt.templates.sifive.ui,
+   org.eclipse.embedcdt.templates.stm,
+   org.eclipse.embedcdt.templates.stm.ui,
+   org.eclipse.embedcdt.ui",
+ org.eclipse.embedcdt.managedbuild.cross.ui

plugins/org.eclipse.embedcdt.managedbuild.packs.ui/META-INF/MANIFEST.MF

@@ -27,6 +27,7 @@ Bundle-ActivationPolicy: lazy
 Bundle-RequiredExecutionEnvironment: JavaSE-11
 Bundle-Vendor: %bundle.vendor
 Bundle-Localization: plugin
-Export-Package: org.eclipse.embedcdt.internal.managedbuild.packs.ui.views,
+Export-Package: org.eclipse.embedcdt.internal.managedbuild.packs.ui;x-internal:=true,
+ org.eclipse.embedcdt.internal.managedbuild.packs.ui.views;x-internal:=true,
  org.eclipse.embedcdt.managedbuild.packs.ui
 Automatic-Module-Name: org.eclipse.embedcdt.managedbuild.packs.ui

plugins/org.eclipse.embedcdt.packs.ui/META-INF/MANIFEST.MF

@@ -20,7 +20,9 @@ Bundle-RequiredExecutionEnvironment: JavaSE-11
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %bundle.vendor
 Bundle-Localization: plugin
-Export-Package: org.eclipse.embedcdt.internal.packs.ui.perspectives,
+Export-Package: org.eclipse.embedcdt.internal.packs.ui;x-internal:=true,
+ org.eclipse.embedcdt.internal.packs.ui.perspectives;x-internal:=true,
+ org.eclipse.embedcdt.internal.packs.ui.views;x-internal:=true,
  org.eclipse.embedcdt.packs.ui,
  org.eclipse.embedcdt.packs.ui.handlers,
  org.eclipse.embedcdt.packs.ui.preferences,