chore: remove component_updated marker

Author: Kelwan

ecsact/entt/event_markers.hh

@@ -10,12 +10,6 @@ namespace ecsact::entt {
 template<typename C>
 struct component_added {};
 
-/**
- * Marker to indicate that a component has been changed during execution
- */
-template<typename C>
-struct component_updated {};
-
 /**
  * Marker to indicate that a component has been removed
  */

ecsact/entt/wrapper/core.hh

@@ -10,6 +10,8 @@
 #include "ecsact/entt/error_check.hh"
 #include "ecsact/entt/detail/execution_events_collector.hh"
 
+#include <iostream>
+
 namespace ecsact::entt::wrapper::core {
 
 template<typename C>
@@ -156,7 +158,6 @@ inline auto update_component_exec_options( //
 
 	if(err == ECSACT_UPDATE_OK) {
 		reg.replace<C>(entity, *static_cast<const C*>(component_data));
-		reg.template emplace_or_replace<component_updated<C>>(entity);
 	}
 
 	return err;
@@ -177,7 +178,6 @@ auto remove_component(
 		reg.remove<detail::exec_beforechange_storage<C>>(entity);
 	}
 	reg.template remove<component_added<C>>(entity);
-	reg.template remove<component_updated<C>>(entity);
 	reg.template emplace_or_replace<component_removed<C>>(entity);
 	ecsact::entt::detail::remove_system_markers_if_needed<C>(reg, entity);
 }
@@ -203,7 +203,6 @@ auto remove_component_exec_options(
 
 	reg.template erase<C>(entity);
 	reg.template remove<component_added<C>>(entity);
-	reg.template remove<component_updated<C>>(entity);
 	reg.template emplace_or_replace<component_removed<C>>(entity);
 
 	if constexpr(!std::is_empty_v<C>) {
@@ -295,7 +294,6 @@ auto _trigger_update_component_event(
 	ecsact_registry_id                                registry_id,
 	ecsact::entt::detail::execution_events_collector& events_collector
 ) -> void {
-	using ecsact::entt::component_updated;
 	using ecsact::entt::detail::exec_beforechange_storage;
 
 	if(!events_collector.has_update_callback()) {
@@ -307,7 +305,6 @@ auto _trigger_update_component_event(
 		::entt::basic_view changed_view{
 			reg.template storage<C>(),
 			reg.template storage<exec_beforechange_storage<C>>(),
-			reg.template storage<component_updated<C>>(),
 		};
 
 		for(ecsact::entt::entity_id entity : changed_view) {
@@ -384,7 +381,6 @@ inline auto clear_component(ecsact_registry_id registry_id) -> void {
 	auto& reg = ecsact::entt::get_registry(registry_id);
 
 	reg.clear<ecsact::entt::component_added<C>>();
-	reg.clear<ecsact::entt::component_updated<C>>();
 	reg.clear<ecsact::entt::component_removed<C>>();
 }
 
@@ -411,7 +407,6 @@ inline auto prepare_component(ecsact_registry_id registry_id) -> void {
 	if constexpr(!std::is_empty_v<C>) {
 		reg.template storage<detail::exec_beforechange_storage<C>>();
 		reg.template storage<detail::exec_itr_beforechange_storage<C>>();
-		reg.template storage<component_updated<C>>();
 	}
 }
 

ecsact/entt/wrapper/dynamic.hh

@@ -75,15 +75,13 @@ auto context_remove(
 	assert(ecsact_id_cast<ecsact_component_like_id>(C::id) == component_id);
 
 	using ecsact::entt::component_removed;
-	using ecsact::entt::component_updated;
 	using ecsact::entt::detail::beforeremove_storage;
 	using ecsact::entt::detail::pending_remove;
 
 	auto  entity = context->entity;
 	auto& registry = *context->registry;
 
 	registry.template remove<component_added<C>>(entity);
-	registry.template remove<component_updated<C>>(entity);
 	registry.template emplace_or_replace<pending_remove<C>>(entity);
 	registry.template emplace_or_replace<component_removed<C>>(entity);
 
@@ -105,12 +103,10 @@ auto component_remove_trivial(
 	auto&                     view
 ) -> void {
 	using ecsact::entt::component_removed;
-	using ecsact::entt::component_updated;
 	using ecsact::entt::detail::beforeremove_storage;
 	using ecsact::entt::detail::pending_remove;
 
 	registry.template remove<component_added<C>>(entity_id);
-	registry.template remove<component_updated<C>>(entity_id);
 	registry.template emplace_or_replace<pending_remove<C>>(entity_id);
 	registry.template emplace_or_replace<component_removed<C>>(entity_id);
 
@@ -146,7 +142,6 @@ auto context_update(
 	const void*                               in_component_data,
 	auto&                                     view
 ) -> void {
-	using ecsact::entt::component_updated;
 	using ecsact::entt::detail::exec_beforechange_storage;
 	// TODO(Kelwan): for remove, beforeremove_storage
 
@@ -161,7 +156,6 @@ auto context_update(
 	if(!beforechange.has_update_occurred) {
 		beforechange.value = current_component;
 		beforechange.has_update_occurred = true;
-		registry.template emplace_or_replace<component_updated<C>>(entity);
 	}
 	current_component = in_component;
 }

rt_entt_codegen/core/system_provider/notify/notify.cc

@@ -129,17 +129,14 @@ auto provider::notify::print_system_notify_views(
 		}
 
 		if(notify_setting == ECSACT_SYS_NOTIFY_ONUPDATE) {
-			auto component_updated_str =
-				std::format("ecsact::entt::component_updated<{}>", cpp_comp_name);
-
 			auto view_name = std::format("{}_update_view", comp_name);
 
 			ecsact::rt_entt_codegen::util::make_view(
 				ctx,
 				view_name,
 				registry_name,
 				system_details,
-				std::vector{component_updated_str},
+				{},
 				std::vector{run_system_comp}
 			);
 

test/runtime_test.cc

@@ -10,6 +10,8 @@
 #include "ecsact/runtime/core.hh"
 #include "ecsact/runtime/dynamic.h"
 
+#include <iostream>
+
 #include "runtime_test.ecsact.hh"
 #include "runtime_test.ecsact.systems.hh"