chore: working needs cleanup

Author: Kelwan

rt_entt_codegen/shared/parallel.cc

@@ -5,6 +5,8 @@
 #include "ecsact/lang-support/lang-cc.hh"
 #include "ecsact/cpp_codegen_plugin_util.hh"
 
+#include <iostream>
+
 struct loop_iterator_fields {
 	std::vector<ecsact_system_like_id>&                system_list;
 	const std::vector<ecsact_system_like_id>::iterator begin;
@@ -147,8 +149,49 @@ auto loop_iterator(
 			return;
 		}
 
+		std::set<ecsact_component_like_id> child_unsafe_comps{};
+
+		auto child_systems = ecsact::meta::get_child_system_ids(sys_like_id);
+
+		for(auto child_sys_id : child_systems) {
+			auto cpp_system_name = decl_full_name(child_sys_id);
+			auto child_capabilities = ecsact::meta::system_capabilities(child_sys_id);
+			for(auto const [child_comp_id, child_capability] : child_capabilities) {
+				if(unsafe_comps.contains(child_comp_id)) {
+					if(child_capability == ECSACT_SYS_CAP_READONLY ||
+						 child_capability == ECSACT_SYS_CAP_OPTIONAL_READONLY) {
+						parallel_system_cluster.push_back(parallel_system_list);
+						loop_iterator(system_list, iterator, parallel_system_cluster);
+						return;
+					}
+				}
+
+				if(!is_capability_safe(child_capability)) {
+					if(unsafe_comps.contains(child_comp_id)) {
+						parallel_system_cluster.push_back(parallel_system_list);
+						loop_iterator(system_list, iterator, parallel_system_cluster);
+						return;
+					} else {
+						child_unsafe_comps.insert(child_comp_id);
+					}
+					// std::cout << " STUCK ON " << cpp_name << "COMPONENT IN THE "
+					// 					<< cpp_system_name << std::endl;
+				}
+			}
+		}
+
 		for(const auto [comp_id, capability] : capabilities) {
 			auto cpp_name = decl_full_name(comp_id);
+
+			if(unsafe_comps.contains(comp_id)) {
+				if(capability == ECSACT_SYS_CAP_READONLY ||
+					 capability == ECSACT_SYS_CAP_OPTIONAL_READONLY) {
+					parallel_system_cluster.push_back(parallel_system_list);
+					loop_iterator(system_list, iterator, parallel_system_cluster);
+					return;
+				}
+			}
+
 			if(!is_capability_safe(capability)) {
 				if(!unsafe_comps.contains(comp_id)) {
 					unsafe_comps.insert(comp_id);
@@ -158,6 +201,7 @@ auto loop_iterator(
 					return;
 				}
 			}
+
 			auto other_fields =
 				ecsact::meta::system_association_fields(sys_like_id, comp_id);
 
@@ -168,7 +212,7 @@ auto loop_iterator(
 					field_id
 				);
 
-				for(auto [other_comp_id, other_capability] : other_capabilities) {
+				for(const auto [other_comp_id, other_capability] : other_capabilities) {
 					auto cpp_name = decl_full_name(other_comp_id);
 					if(!is_capability_safe(other_capability)) {
 						if(!unsafe_comps.contains(other_comp_id)) {
@@ -182,6 +226,13 @@ auto loop_iterator(
 				}
 			}
 		}
+
+		for(auto unsafe_comp : child_unsafe_comps) {
+			if(!unsafe_comps.contains(unsafe_comp)) {
+				unsafe_comps.insert(unsafe_comp);
+			}
+		}
+
 		parallel_system_list.push_back(sys_like_id);
 	}
 	parallel_system_cluster.push_back(parallel_system_list);

test/parallel/parallel_test.ecsact

@@ -63,4 +63,11 @@ system ReadParallelBB {
     readonly ParallelB;
 }
 
+system ParentSharedComponent {
+    readwrite ParallelA;
+    system ChildSharedComponent {
+        readwrite ParallelA;
+    }
+}
+