fix inconsistency with field get using typed vs void

Author: zaucy

WORKSPACE.bazel

@@ -18,9 +18,9 @@ http_archive(
 
 http_archive(
     name = "ecsact_lang_cpp",
-    sha256 = "f66c5d31cc303022c313a424f4c432c41ff517b73143915436c6c6f06a969a47",
-    strip_prefix = "ecsact_lang_cpp-34d73ebce5e99ae9711efa79a30ca7acda8599f0",
-    url = "https://github.com/ecsact-dev/ecsact_lang_cpp/archive/34d73ebce5e99ae9711efa79a30ca7acda8599f0.zip",
+    sha256 = "2866569ed8d58f3e42b705bf38f77455fe9acf8ab2d1b05f611b847d4c291a67",
+    strip_prefix = "ecsact_lang_cpp-b1fa28b445b98d5ba62ede19cd6a5bdfa51141be",
+    url = "https://github.com/ecsact-dev/ecsact_lang_cpp/archive/b1fa28b445b98d5ba62ede19cd6a5bdfa51141be.zip",
 )
 
 load("@rules_ecsact//ecsact:repositories.bzl", "ecsact_register_toolchains", "rules_ecsact_dependencies")

ecsact/entt/detail/registry_info.hh

@@ -60,7 +60,7 @@ struct registry_info {
 		using boost::mp11::mp_with_index;
 		using ecsact::entt::detail::association;
 
-		auto entity_field = field.template get<ecsact_entity_id>(component);
+		auto entity_field = field.template get<ecsact_entity_id>(&component);
 		auto entity_field_entt = entities_map.at(entity_field);
 		mp_with_index<64>(field.offset, [&](auto I) {
 			registry.emplace<association<C, I>>(entity_field_entt);
@@ -75,7 +75,7 @@ struct registry_info {
 		using boost::mp11::mp_with_index;
 		using ecsact::entt::detail::association;
 
-		auto entity_field = field.template get<ecsact_entity_id>(component);
+		auto entity_field = field.template get<ecsact_entity_id>(&component);
 		auto entity_field_entt = entities_map.at(entity_field);
 		mp_with_index<64>(field.offset, [&](auto I) {
 			registry.erase<association<C, I>>(entity_field_entt);

ecsact/entt/runtime.hh

@@ -199,7 +199,7 @@ public:
 			for(auto& field : fields_info) {
 				if(field.storage_type == ECSACT_ENTITY_TYPE) {
 					auto entity_field =
-						field.template get<ecsact_entity_id>(component_data);
+						field.template get<ecsact_entity_id>(&component_data);
 					if(!info.entities_map.contains(entity_field)) {
 						return ECSACT_ADD_ERR_ENTITY_INVALID;
 					}
@@ -397,7 +397,7 @@ public:
 			for(auto& field : fields_info) {
 				if(field.storage_type == ECSACT_ENTITY_TYPE) {
 					auto entity_field =
-						field.template get<ecsact_entity_id>(component_data);
+						field.template get<ecsact_entity_id>(&component_data);
 					if(!info.entities_map.contains(entity_field)) {
 						return ECSACT_UPDATE_ERR_ENTITY_INVALID;
 					}

runtime/test/runtime_test.cc

@@ -423,7 +423,8 @@ TEST(Core, DynamicSystemImpl) {
 		&runtime_test__OtherEntitySystem
 	);
 
-	ecsact_execute_systems(reg.id(), 1, nullptr, nullptr);
+	auto exec_err = ecsact_execute_systems(reg.id(), 1, nullptr, nullptr);
+	ASSERT_EQ(exec_err, ECSACT_EXEC_SYS_OK);
 
 	// Sanity check
 	ASSERT_TRUE(reg.has_component<ComponentA>(entity));
@@ -439,12 +440,10 @@ TEST(Core, DynamicSystemImpl) {
 
 TEST(Core, ExecuteSystemsErrors) {
 	auto reg = ecsact::core::registry("ExecuteSystemsErrors");
-	auto comp = OtherEntityComponent{
-		.num = 42,
-		.target = static_cast<ecsact_entity_id>(4000),
-	};
 	auto options = ecsact_execution_options{};
-	auto test_action = runtime_test::AssocTestAction{};
+	auto test_action = runtime_test::AssocTestAction{
+		.assoc_entity = static_cast<ecsact_entity_id>(4000),
+	};
 	auto test_action_c = ecsact_action{
 		.action_id = runtime_test::AssocTestAction::id,
 		.action_data = &test_action,
@@ -457,6 +456,26 @@ TEST(Core, ExecuteSystemsErrors) {
 	EXPECT_EQ(exec_err, ECSACT_EXEC_SYS_ERR_ACTION_ENTITY_INVALID);
 }
 
+TEST(Core, ExecuteSystemsAssocActionOk) {
+	auto reg = ecsact::core::registry("ExecuteSystemsErrors");
+	auto test_entity = reg.create_entity();
+
+	auto options = ecsact_execution_options{};
+	auto test_action = runtime_test::AssocTestAction{
+		.assoc_entity = test_entity,
+	};
+	auto test_action_c = ecsact_action{
+		.action_id = runtime_test::AssocTestAction::id,
+		.action_data = &test_action,
+	};
+
+	options.actions_length = 1;
+	options.actions = &test_action_c;
+	auto exec_err = ecsact_execute_systems(reg.id(), 1, &options, nullptr);
+
+	EXPECT_EQ(exec_err, ECSACT_EXEC_SYS_OK);
+}
+
 TEST(Core, AssociationEntityCorrectness) {
 	using runtime_test::AttackDamage;
 	using runtime_test::AttackDamageWeakened;