no warnings (#137)

Author: zaucy

.bazelrc

@@ -11,6 +11,9 @@ build:windows --host_platform=@ecsact_runtime//bazel/platforms:windows
 build:linux --platforms=@ecsact_runtime//bazel/platforms:linux
 build:linux --extra_toolchains=@llvm_toolchain//:cc-toolchain-x86_64-linux
 
+build:no-warnings --per_file_copt=//.*@-Werror
+
+common:linux:ci --config=no-warnings
 common:ci --announce_rc
 common:ci --disk_cache=~/.cache/bazel-disk-cache
 test:ci --test_output=errors

dylib/dylib-util.hh

@@ -1,6 +1,6 @@
 #pragma once
 
 #define ECSACT_DYLIB_UTIL_FN_PTR_DEFN(fn_name, unused) \
-	decltype(::fn_name)(::fn_name) = nullptr
+	decltype(fn_name)(fn_name) = nullptr
 
-#define ECSACT_DYLIB_UTIL_FN_PTR_ASSIGN(fn_name) (::fn_name) = nullptr
+#define ECSACT_DYLIB_UTIL_FN_PTR_ASSIGN(fn_name) (fn_name) = nullptr

dylib/dylib.cc

@@ -47,10 +47,10 @@ FOR_EACH_ECSACT_SERIALIZE_API_FN(ECSACT_DYLIB_UTIL_FN_PTR_DEFN);
 #define HAS_FN_CHECK(fn_name, target_fn_name) \
 	if(std::strcmp(target_fn_name, #fn_name) == 0) return true
 
-#define ASSIGN_FN_IF(fn_name, target_fn_name, fn_ptr)          \
-	if(std::strcmp(#fn_name, target_fn_name) == 0) {             \
-		::fn_name = reinterpret_cast<decltype(::fn_name)>(fn_ptr); \
-	}                                                            \
+#define ASSIGN_FN_IF(fn_name, target_fn_name, fn_ptr)      \
+	if(std::strcmp(#fn_name, target_fn_name) == 0) {         \
+		fn_name = reinterpret_cast<decltype(fn_name)>(fn_ptr); \
+	}                                                        \
 	static_assert(true, "macro requires ;")
 
 bool ecsact_dylib_has_fn(const char* fn_name) {

reference/async_reference/async_reference.cc

@@ -124,7 +124,6 @@ void async_reference::execute_systems() {
 	execution_thread = std::thread([this] {
 		using namespace std::chrono_literals;
 		using clock = std::chrono::high_resolution_clock;
-		using milliseconds = std::chrono::milliseconds;
 		using nanoseconds = std::chrono::nanoseconds;
 		using std::chrono::duration_cast;
 

reference/async_reference/util/util.cc

@@ -20,8 +20,7 @@ static ecsact_async_error validate_instructions(
 	for(auto& component : components) {
 		auto view = std::views::filter(
 			components_range,
-			[&components_range,
-			 &component](types::cpp_execution_component other_component) {
+			[&component](types::cpp_execution_component other_component) {
 				return component._id == other_component._id;
 			}
 		);
@@ -52,8 +51,6 @@ ecsact_async_error validate_merge_instructions(
 	auto entities = util::get_cpp_entities(components);
 	auto other_entities = util::get_cpp_entities(other_components);
 
-	auto empty_view = std::ranges::empty_view<int>{};
-
 	auto has_duplicates =
 		util::check_entity_merge_duplicates(entities, other_entities);
 
@@ -64,8 +61,7 @@ ecsact_async_error validate_merge_instructions(
 	for(auto& component : components) {
 		auto component_view = std::views::filter(
 			other_components,
-			[&other_components,
-			 &component](types::cpp_execution_component other_component) {
+			[&component](types::cpp_execution_component other_component) {
 				return component._id == other_component._id;
 			}
 		);

reference/async_reference/util/util.hh

@@ -50,7 +50,7 @@ bool check_entity_duplicates(auto entities_view) {
 				return entity_id == other_entity;
 			});
 		int same_entity_count = 0;
-		for(auto _ : duplicate_view) {
+		for([[maybe_unused]] auto _ : duplicate_view) {
 			same_entity_count++;
 			if(same_entity_count > 1) {
 				return true;
@@ -71,7 +71,7 @@ bool check_entity_merge_duplicates(
 			});
 
 		int same_entity_count = 0;
-		for(auto _ : duplicate_view) {
+		for([[maybe_unused]] auto _ : duplicate_view) {
 			same_entity_count++;
 			if(same_entity_count > 0) {
 				return true;