Open external links in another tab (#793)

* Open external links in another tab

* Fix

* Fix tests

---------

Co-authored-by: Felipe Cotti <[email protected]>

Author: reakaleek

src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs

@@ -131,9 +131,11 @@ private static void ValidateAndProcessLink(LinkInline link, InlineProcessor proc
 
 		if (IsCrossLink(uri))
 		{
+			link.SetData("isCrossLink", true);
 			ProcessCrossLink(link, processor, context, uri);
 			return;
 		}
+		link.SetData("isCrossLink", false);
 
 		if (ValidateExternalUri(link, processor, uri))
 			return;

src/Elastic.Markdown/Myst/Renderers/HtmxLinkInlineRenderer.cs

@@ -17,7 +17,7 @@ public class HtmxLinkInlineRenderer : LinkInlineRenderer
 {
 	protected override void Write(HtmlRenderer renderer, LinkInline link)
 	{
-		if (renderer.EnableHtmlForInline && !link.IsImage && link.Url?.StartsWith('/') == true)
+		if (renderer.EnableHtmlForInline && !link.IsImage)
 		{
 			// ReSharper disable once UnusedVariable
 			if (link.GetData(nameof(ParserContext.CurrentUrlPath)) is not string currentUrl)
@@ -26,21 +26,32 @@ protected override void Write(HtmlRenderer renderer, LinkInline link)
 				return;
 			}
 
-			var currentRootNavigation = link.GetData(nameof(MarkdownFile.RootNavigation)) as INavigation;
-			var targetRootNavigation = link.GetData($"Target{nameof(MarkdownFile.RootNavigation)}") as INavigation;
+			var url = link.GetDynamicUrl != null ? link.GetDynamicUrl() : link.Url;
 
 			_ = renderer.Write("<a href=\"");
-			_ = renderer.WriteEscapeUrl(link.GetDynamicUrl != null ? link.GetDynamicUrl() : link.Url);
+			_ = renderer.WriteEscapeUrl(url);
 			_ = renderer.Write('"');
 			_ = renderer.WriteAttributes(link);
-			_ = renderer.Write(" hx-get=\"");
-			_ = renderer.WriteEscapeUrl(link.GetDynamicUrl != null ? link.GetDynamicUrl() : link.Url);
-			_ = renderer.Write('"');
-			_ = renderer.Write($" hx-select-oob=\"{Htmx.GetHxSelectOob(currentRootNavigation?.Id == targetRootNavigation?.Id)}\"");
-			_ = renderer.Write(" hx-swap=\"none\"");
-			_ = renderer.Write(" hx-push-url=\"true\"");
-			_ = renderer.Write(" hx-indicator=\"#htmx-indicator\"");
-			_ = renderer.Write($" preload=\"{Htmx.GetPreload()}\"");
+
+
+			if (link.Url?.StartsWith('/') == true)
+			{
+				var currentRootNavigation = link.GetData(nameof(MarkdownFile.RootNavigation)) as INavigation;
+				var targetRootNavigation = link.GetData($"Target{nameof(MarkdownFile.RootNavigation)}") as INavigation;
+				_ = renderer.Write(" hx-get=\"");
+				_ = renderer.WriteEscapeUrl(url);
+				_ = renderer.Write('"');
+				_ = renderer.Write($" hx-select-oob=\"{Htmx.GetHxSelectOob(currentRootNavigation?.Id == targetRootNavigation?.Id)}\"");
+				_ = renderer.Write(" hx-swap=\"none\"");
+				_ = renderer.Write(" hx-push-url=\"true\"");
+				_ = renderer.Write(" hx-indicator=\"#htmx-indicator\"");
+				_ = renderer.Write($" preload=\"{Htmx.GetPreload()}\"");
+			}
+			else if (link.Url?.StartsWith("http") == true && (link.GetData("isCrossLink") as bool?) == false)
+			{
+				_ = renderer.Write(" target=\"_blank\"");
+				_ = renderer.Write(" rel=\"noopener noreferrer\"");
+			}
 
 			if (!string.IsNullOrEmpty(link.Title))
 			{
@@ -49,7 +60,7 @@ protected override void Write(HtmlRenderer renderer, LinkInline link)
 				_ = renderer.Write('"');
 			}
 
-			if (!string.IsNullOrWhiteSpace(Rel))
+			if (!string.IsNullOrWhiteSpace(Rel) && link.Url?.StartsWith('/') == false)
 			{
 				_ = renderer.Write(" rel=\"");
 				_ = renderer.Write(Rel);

tests/Elastic.Markdown.Tests/Inline/InlineLinkTests.cs

@@ -194,7 +194,7 @@ [link to app]({{some-url-with-a-version}})
 	public void GeneratesHtml() =>
 		// language=html
 		Html.Should().Contain(
-			"""<p><a href="https://github.com/elastic/fake-repo/tree/v1.17.0">link to app</a></p>"""
+			"""<p><a href="https://github.com/elastic/fake-repo/tree/v1.17.0" target="_blank" rel="noopener noreferrer">link to app</a></p>"""
 		);
 
 	[Fact]