Skip to content

Commit ce7bbb8

Browse files
committed
Fix master compilation from ES on Java 11 (#1283)
Elasticsearch bumped the compiled version to 11 on the server artifacts. ES-Hadoop is still based on Java 8 for the time being, and the only use for the Elasticsearch artifacts are for testing. We can add the verification back in when we bump up the java compiler version in the project.
1 parent dd298b9 commit ce7bbb8

File tree

2 files changed

+55
-59
lines changed

2 files changed

+55
-59
lines changed

buildSrc/src/main/groovy/org/elasticsearch/hadoop/gradle/BuildPlugin.groovy

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -238,12 +238,7 @@ class BuildPlugin implements Plugin<Project> {
238238
testCompile "junit:junit:${project.ext.junitVersion}"
239239
testCompile "org.hamcrest:hamcrest-all:${project.ext.hamcrestVersion}"
240240

241-
testCompile("org.elasticsearch:elasticsearch:${project.ext.elasticsearchVersion}") {
242-
exclude group: "org.apache.logging.log4j", module: "log4j-api"
243-
exclude group: "org.elasticsearch", module: "elasticsearch-cli"
244-
exclude group: "org.elasticsearch", module: "elasticsearch-core"
245-
exclude group: "org.elasticsearch", module: "elasticsearch-secure-sm"
246-
}
241+
testCompile "joda-time:joda-time:2.8"
247242

248243
testRuntime "org.slf4j:slf4j-log4j12:1.7.6"
249244
testRuntime "org.apache.logging.log4j:log4j-api:${project.ext.log4jVersion}"

mr/src/test/java/org/elasticsearch/hadoop/util/EsMajorVersionTest.java

Lines changed: 54 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -18,82 +18,83 @@
1818
*/
1919
package org.elasticsearch.hadoop.util;
2020

21-
import org.elasticsearch.Version;
22-
import org.junit.Test;
23-
24-
import java.lang.reflect.Field;
25-
import java.lang.reflect.Modifier;
2621
import java.util.ArrayList;
2722
import java.util.Collections;
28-
import java.util.HashSet;
2923
import java.util.List;
30-
import java.util.Set;
3124

32-
import static org.hamcrest.CoreMatchers.equalTo;
25+
import org.junit.Test;
26+
3327
import static org.junit.Assert.assertFalse;
34-
import static org.junit.Assert.assertThat;
3528
import static org.junit.Assert.assertTrue;
3629

3730
public class EsMajorVersionTest {
38-
private static final List<Version> SORTED_VERSIONS;
39-
31+
private static final List<String> TEST_VERSIONS;
4032
static {
41-
Field[] declaredFields = Version.class.getFields();
42-
Set<Integer> ids = new HashSet<Integer>();
43-
for (Field field : declaredFields) {
44-
final int mod = field.getModifiers();
45-
if (Modifier.isStatic(mod) && Modifier.isFinal(mod) && Modifier.isPublic(mod)) {
46-
if (field.getType() == Version.class) {
47-
try {
48-
Version object = (Version) field.get(null);
49-
ids.add(object.id);
50-
} catch (IllegalAccessException e) {
51-
throw new RuntimeException(e);
52-
}
53-
}
54-
}
55-
}
56-
List<Integer> idList = new ArrayList<Integer>(ids);
57-
Collections.sort(idList);
58-
List<Version> version = new ArrayList<Version>();
59-
for (Integer integer : idList) {
60-
version.add(Version.fromId(integer));
61-
}
62-
SORTED_VERSIONS = Collections.unmodifiableList(version);
33+
List<String> versions = new ArrayList<>();
34+
versions.add("0.1.0");
35+
versions.add("0.1.1");
36+
versions.add("1.0.0-alpha1");
37+
versions.add("1.0.0-beta2");
38+
versions.add("1.0.0-rc3");
39+
versions.add("1.0.0");
40+
versions.add("1.1.0");
41+
versions.add("1.1.1");
42+
versions.add("2.0.0-alpha1");
43+
versions.add("2.0.0-beta2");
44+
versions.add("2.0.0-rc3");
45+
versions.add("2.0.0");
46+
versions.add("2.1.0");
47+
versions.add("2.1.1");
48+
versions.add("5.0.0-alpha1");
49+
versions.add("5.0.0-beta2");
50+
versions.add("5.0.0-rc3");
51+
versions.add("5.0.0");
52+
versions.add("5.1.0");
53+
versions.add("5.1.1");
54+
versions.add("6.0.0-alpha1");
55+
versions.add("6.0.0-beta2");
56+
versions.add("6.0.0-rc3");
57+
versions.add("6.0.0");
58+
versions.add("6.1.0");
59+
versions.add("6.1.1");
60+
versions.add("7.0.0-alpha1");
61+
versions.add("7.0.0-beta2");
62+
versions.add("7.0.0-rc3");
63+
versions.add("7.0.0");
64+
versions.add("7.1.0");
65+
versions.add("7.1.1");
66+
versions.add("8.0.0-alpha1");
67+
versions.add("8.0.0-beta2");
68+
versions.add("8.0.0-rc3");
69+
versions.add("8.0.0");
70+
versions.add("8.1.0");
71+
versions.add("8.1.1");
72+
TEST_VERSIONS = Collections.unmodifiableList(versions);
6373
}
6474

6575

6676
@Test
6777
public void testVersionFromString() {
68-
for (int i = 0; i < SORTED_VERSIONS.size(); i++) {
69-
Version official = SORTED_VERSIONS.get(i);
70-
EsMajorVersion version = EsMajorVersion.parse(official.toString());
71-
EsMajorVersion version2 = EsMajorVersion.parse(official.toString());
72-
assertThat(version.major,
73-
equalTo(official.major));
78+
for (int i = 0; i < TEST_VERSIONS.size(); i++) {
79+
String testVersion = TEST_VERSIONS.get(i);
80+
EsMajorVersion version = EsMajorVersion.parse(testVersion);
81+
EsMajorVersion version2 = EsMajorVersion.parse(testVersion);
7482
assertTrue(version.onOrAfter(version));
7583
assertTrue(version.equals(version));
7684
assertTrue(version.equals(version2));
77-
for (int j = i + 1; j < SORTED_VERSIONS.size(); j++) {
78-
Version cmp_official = SORTED_VERSIONS.get(j);
79-
EsMajorVersion cmp_version = EsMajorVersion.parse(cmp_official.toString());
80-
assertThat(cmp_version.after(version), equalTo(cmp_official.major != official.major));
81-
assertTrue(cmp_version.onOrAfter(version));
82-
assertFalse(cmp_version.equals(version));
85+
for (int j = i + 1; j < TEST_VERSIONS.size(); j++) {
86+
String laterTestVersion = TEST_VERSIONS.get(j);
87+
EsMajorVersion compareVersion = EsMajorVersion.parse(laterTestVersion);
88+
assertTrue(compareVersion.onOrAfter(version));
89+
assertFalse(compareVersion.equals(version));
8390
}
8491

8592
for (int j = i - 1; j >= 0; j--) {
86-
Version cmp_official = SORTED_VERSIONS.get(j);
87-
EsMajorVersion cmp_version = EsMajorVersion.parse(cmp_official.toString());
88-
assertThat(cmp_version.before(version), equalTo(cmp_official.major != official.major));
93+
String earlierTestVersion = TEST_VERSIONS.get(j);
94+
EsMajorVersion cmp_version = EsMajorVersion.parse(earlierTestVersion);
8995
assertTrue(cmp_version.onOrBefore(version));
9096
assertFalse(cmp_version.equals(version));
9197
}
9298
}
9399
}
94-
95-
@Test
96-
public void testLatestIsCurrent() {
97-
assertThat(EsMajorVersion.LATEST.major, equalTo(Version.CURRENT.major));
98-
}
99100
}

0 commit comments

Comments
 (0)