todos and timeouts fix

Author: l-trotta

java-client/src/main/java/co/elastic/clients/transport/rest5_client/low_level/BufferedByteConsumer.java

@@ -55,7 +55,7 @@ protected int capacityIncrement() {
 
     @Override
     protected void data(final ByteBuffer src, final boolean endOfStream) throws ContentTooLongException {
-        if (src.capacity() > limit) { //TODO why though? the server already has a 100MB limit. also, this method is called multiple times. check if should be src.capacity + buffer.length
+        if (src.capacity() > limit) {
             throw new ContentTooLongException(
                 "entity content is too long [" + src.capacity() + "] for the configured buffer limit [" + limit + "]"
             );

java-client/src/main/java/co/elastic/clients/transport/rest5_client/low_level/Rest5Client.java

@@ -219,16 +219,15 @@ public HttpAsyncClient getHttpClient() {
     /**
      * Replaces the nodes with which the client communicates.
      */
-    public synchronized void setNodes(Collection<Node> nodes) { // TODO why the whole method synchronized?
+    public synchronized void setNodes(Collection<Node> nodes) {
         if (nodes == null || nodes.isEmpty()) {
             throw new IllegalArgumentException("node list must not be null or empty");
         }
 
         Map<HttpHost, Node> nodesByHost = new LinkedHashMap<>();
         for (Node node : nodes) {
             Objects.requireNonNull(node, "node cannot be null");
-            nodesByHost.put(node.getHost(), node); // TODO same host twice will be overwritten. should
-            // throw exception?
+            nodesByHost.put(node.getHost(), node);
         }
         this.nodes = new ArrayList<>(nodesByHost.values());
         this.blacklist.clear();

java-client/src/main/java/co/elastic/clients/transport/rest5_client/low_level/Rest5ClientBuilder.java

@@ -20,6 +20,7 @@
 package co.elastic.clients.transport.rest5_client.low_level;
 
 
+import org.apache.hc.client5.http.config.ConnectionConfig;
 import org.apache.hc.client5.http.config.RequestConfig;
 import org.apache.hc.client5.http.impl.DefaultAuthenticationStrategy;
 import org.apache.hc.client5.http.impl.async.CloseableHttpAsyncClient;
@@ -55,6 +56,7 @@
 public final class Rest5ClientBuilder {
     public static final int DEFAULT_CONNECT_TIMEOUT_MILLIS = 1000;
     public static final int DEFAULT_SOCKET_TIMEOUT_MILLIS = 30000;
+    public static final int DEFAULT_RESPONSE_TIMEOUT_MILLIS = 0; // meaning infinite
     public static final int DEFAULT_MAX_CONN_PER_ROUTE = 10;
     public static final int DEFAULT_MAX_CONN_TOTAL = 30;
 
@@ -343,24 +345,30 @@ private CloseableHttpAsyncClient createHttpClient() {
             return this.httpClient;
         }
         // otherwise, creating a default instance of CloseableHttpAsyncClient
-        // default timeouts are all infinite
-        RequestConfig.Builder requestConfigBuilder = RequestConfig.custom()
+        // default timeouts are all 3 mins
+        RequestConfig requestConfigBuilder = RequestConfig.custom()
             .setConnectionRequestTimeout(Timeout.of(DEFAULT_SOCKET_TIMEOUT_MILLIS, TimeUnit.MILLISECONDS))
-            .setConnectTimeout(Timeout.of(DEFAULT_CONNECT_TIMEOUT_MILLIS, TimeUnit.MILLISECONDS)); //TODO deprecated need to change
+            .setResponseTimeout(Timeout.of(DEFAULT_RESPONSE_TIMEOUT_MILLIS, TimeUnit.MILLISECONDS))
+            .build();
 
         try {
 
             SSLContext sslContext = this.sslContext != null ? this.sslContext : SSLContext.getDefault();
 
+            ConnectionConfig connectionConfig = ConnectionConfig.custom()
+                .setConnectTimeout(Timeout.of(DEFAULT_CONNECT_TIMEOUT_MILLIS, TimeUnit.MILLISECONDS))
+                .build();
+
             PoolingAsyncClientConnectionManager defaultConnectionManager =
                 PoolingAsyncClientConnectionManagerBuilder.create()
+                    .setDefaultConnectionConfig(connectionConfig)
                     .setMaxConnPerRoute(DEFAULT_MAX_CONN_PER_ROUTE)
                     .setMaxConnTotal(DEFAULT_MAX_CONN_TOTAL)
                     .setTlsStrategy(new BasicClientTlsStrategy(sslContext))
                     .build();
 
             HttpAsyncClientBuilder httpClientBuilder = HttpAsyncClientBuilder.create()
-                .setDefaultRequestConfig(requestConfigBuilder.build())
+                .setDefaultRequestConfig(requestConfigBuilder)
                 .setConnectionManager(defaultConnectionManager)
                 .setUserAgent(USER_AGENT_HEADER_VALUE)
                 .setTargetAuthenticationStrategy(new DefaultAuthenticationStrategy())