Skip to content

Commit 1adc8c3

Browse files
authored
Fix version bump script (#2054)
* Fix version bump script failure It was trying to run `.replace` on a Buffer instead of a string. * Correctly set Node version in Docker
1 parent 2d139e5 commit 1adc8c3

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.ci/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
ARG NODE_JS_VERSION=18
1+
ARG NODE_JS_VERSION=${NODE_JS_VERSION:-18}
22
FROM node:${NODE_JS_VERSION}
33

44
ARG BUILDER_UID=1000

.ci/make.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,10 @@ async function bump (args) {
8686
'utf8'
8787
)
8888

89-
const pipeline = await readFile(join(import.meta.url, '..', '.buildkite', 'pipeline.yml'))
89+
const pipeline = await readFile(join(import.meta.url, '..', '.buildkite', 'pipeline.yml'), 'utf8')
9090
await writeFile(
9191
join(import.meta.url, '..', '.buildkite', 'pipeline.yml'),
92-
pipeline.replace(/STACK_VERSION: [0-9]+[0-9\.]*[0-9](?:\-SNAPSHOT)?/, `STACK_VERSION: ${cleanVersion}-SNAPSHOT`), // eslint-disable-line
92+
pipeline.replace(/STACK_VERSION: [0-9]+[0-9\.]*[0-9](?:\-SNAPSHOT)?/, `STACK_VERSION: ${cleanVersion}-SNAPSHOT`),
9393
'utf8'
9494
)
9595
}

0 commit comments

Comments
 (0)