Skip to content

Commit 57bfccc

Browse files
committed
Merge pull request #2 from spenceralger/master
Documentation improvements, dep management
2 parents 81225a3 + 671280a commit 57bfccc

File tree

19 files changed

+2280
-33348
lines changed

19 files changed

+2280
-33348
lines changed

Gruntfile.js

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -158,24 +158,12 @@ module.exports = function (grunt) {
158158
}
159159
}
160160
}
161-
},
162-
mocha: {
163-
yaml_suite: {
164-
options: {
165-
// log: true,
166-
run: true,
167-
urls: [ 'http://localhost:8888' ],
168-
timeout: 10e3,
169-
'--web-security': false
170-
}
171-
}
172161
}
173162
});
174163

175164
// load plugins
176165
grunt.loadNpmTasks('grunt-run');
177166
grunt.loadNpmTasks('grunt-open');
178-
grunt.loadNpmTasks('grunt-mocha');
179167
grunt.loadNpmTasks('grunt-browserify');
180168
grunt.loadNpmTasks('grunt-mocha-test');
181169
grunt.loadNpmTasks('grunt-contrib-clean');
@@ -188,11 +176,9 @@ module.exports = function (grunt) {
188176
grunt.registerTask('default', [
189177
/*jshint scripturl:true*/
190178
'jshint',
191-
'mochaTest:unit',
192179
'build',
193-
'mochaTest:yaml_suite',
194-
// 'start:integration_server',
195-
// 'mocha:yaml_suite' -- this will fail because of the way that PhantomJS handle's DELETE requests with body's
180+
'mochaTest:unit',
181+
'mochaTest:yaml_suite'
196182
]);
197183

198184
grunt.registerTask('build', [
@@ -227,6 +213,11 @@ module.exports = function (grunt) {
227213

228214
var taskData = this.data;
229215

216+
/**
217+
* You must always run the build task first, to ensure that the lastest API and yaml tests are available.
218+
* This is run in the default and browser_tests:{{browser}} tests.
219+
*/
220+
grunt.task.requires('build');
230221
grunt.task.requires('run:integration_server');
231222

232223
grunt.config.set('open.yaml_suite_' + this.target, {

README.md

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Official *low-level* client for Elasticsearch.
55
## Features
66

77
- One-to-one mapping with REST API and other language clients
8-
- Generalized, pluggable architecture. See [replacing core components](TODO: details the peices that are replaceable)
8+
- Generalized, pluggable architecture. See [replacing core components](docs/replacing_core_components.md)
99
- Configurable, automatic discovery of cluster nodes
1010
- Persistent, Keep-Alive connections
1111
- Load balancing (with pluggable selection strategy) across all available nodes.
@@ -59,6 +59,14 @@ bower install elasticsearch-angular
5959
bower install elasticsearch-jquery
6060
```
6161

62+
## Docs
63+
- [Configuration](#configuration)
64+
- [API](docs/api.md)
65+
- [Replacing Core Components](docs/replacing_core_components.md)
66+
- [Errors](docs/errors.md)
67+
- [Setting Up Logging](docs/setting_up_logging.md)
68+
- [FAQ](#faq)
69+
6270
## Configuration
6371

6472
The `Client` constructor accepts a single object as it's argument, and the following keys can be used to configure that client instance:
@@ -95,7 +103,7 @@ log: {
95103
}
96104
```
97105

98-
Unless a constructor is specified, this sets the output settings for the bundled logger. See [setting up logging](TODO: detail logging why) for more information.
106+
Unless a constructor is specified, this sets the output settings for the bundled logger. See [setting up logging](docs/setting_up_logging.md) for more information.
99107

100108
### connectionClass
101109
Type: `String`, `Constructor`
@@ -148,7 +156,7 @@ Type: `Number`
148156

149157
Defailt: `3`
150158

151-
How many times should the client try to connect to other nodes before returning a [ConnectionFault](TODO: error types) error. (see [node death](#node-death))
159+
How many times should the client try to connect to other nodes before returning a [ConnectionFault](docs/error.md#connectionfault) error. (see [node death](#node-death))
152160

153161
### timeout
154162
Type: `Number`
@@ -202,7 +210,7 @@ The number of milliseconds this request has to complete. It defaults to the time
202210

203211
### Methods
204212

205-
All the methods can be seen [here](TODO: api docs), or take a look at [api.js](src/lib/api.js).
213+
All the methods can be seen [here](docs/api.md), or take a look at [api.js](src/lib/api.js).
206214

207215
### Examples
208216

0 commit comments

Comments
 (0)