Add data field in serialization errors (#1100)

* Add data field in serialization errors

* Add test for data field in serialization errors

Co-authored-by: Tomas Della Vedova <[email protected]>

Author: killua1zoldyck

lib/Serializer.js

@@ -15,7 +15,7 @@ class Serializer {
     try {
       var json = JSON.stringify(object)
     } catch (err) {
-      throw new SerializationError(err.message)
+      throw new SerializationError(err.message, object)
     }
     return json
   }
@@ -25,7 +25,7 @@ class Serializer {
     try {
       var object = sjson.parse(json)
     } catch (err) {
-      throw new DeserializationError(err.message)
+      throw new DeserializationError(err.message, json)
     }
     return object
   }

lib/errors.d.ts

@@ -33,13 +33,15 @@ export declare class NoLivingConnectionsError extends ElasticsearchClientError {
 export declare class SerializationError extends ElasticsearchClientError {
   name: string;
   message: string;
-  constructor(message: string);
+  data: object;
+  constructor(message: string, data: object);
 }
 
 export declare class DeserializationError extends ElasticsearchClientError {
   name: string;
   message: string;
-  constructor(message: string);
+  data: string;
+  constructor(message: string, data: string);
 }
 
 export declare class ConfigurationError extends ElasticsearchClientError {

lib/errors.js

@@ -42,20 +42,22 @@ class NoLivingConnectionsError extends ElasticsearchClientError {
 }
 
 class SerializationError extends ElasticsearchClientError {
-  constructor (message) {
-    super(message)
+  constructor (message, data) {
+    super(message, data)
     Error.captureStackTrace(this, SerializationError)
     this.name = 'SerializationError'
     this.message = message || 'Serialization Error'
+    this.data = data
   }
 }
 
 class DeserializationError extends ElasticsearchClientError {
-  constructor (message) {
-    super(message)
+  constructor (message, data) {
+    super(message, data)
     Error.captureStackTrace(this, DeserializationError)
     this.name = 'DeserializationError'
     this.message = message || 'Deserialization Error'
+    this.data = data
   }
 }
 

test/unit/errors.test.js

@@ -44,6 +44,7 @@ test('SerializationError', t => {
   t.true(err instanceof Error)
   t.true(err instanceof errors.ElasticsearchClientError)
   t.false(err.hasOwnProperty('meta'))
+  t.true(err.hasOwnProperty('data'))
   t.end()
 })
 
@@ -52,6 +53,7 @@ test('DeserializationError', t => {
   t.true(err instanceof Error)
   t.true(err instanceof errors.ElasticsearchClientError)
   t.false(err.hasOwnProperty('meta'))
+  t.true(err.hasOwnProperty('data'))
   t.end()
 })