Skip to content

Commit fc6b646

Browse files
committed
Improved integration test runner
1 parent e806a14 commit fc6b646

File tree

1 file changed

+23
-20
lines changed

1 file changed

+23
-20
lines changed

test/integration/index.js

Lines changed: 23 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -80,28 +80,28 @@ const customSkips = [
8080
]
8181
const platinumBlackList = {
8282
// file path: test name
83-
'cat.aliases/10_basic.yml': 'Empty cluster',
84-
'index/10_with_id.yml': 'Index with ID',
85-
'indices.get_alias/10_basic.yml': 'Get alias against closed indices',
86-
'indices.get_alias/20_empty.yml': 'Check empty aliases when getting all aliases via /_alias',
83+
'cat.aliases/10_basic.yml': ['Empty cluster'],
84+
'index/10_with_id.yml': ['Index with ID'],
85+
'indices.get_alias/10_basic.yml': ['Get alias against closed indices'],
86+
'indices.get_alias/20_empty.yml': ['Check empty aliases when getting all aliases via /_alias'],
8787
// https://github.com/elastic/elasticsearch/pull/39400
88-
'ml/jobs_crud.yml': 'Test put job with id that is already taken',
88+
'ml/jobs_crud.yml': ['Test put job with id that is already taken'],
8989
// TODO: investigate why this is failing
90-
'monitoring/bulk/10_basic.yml': '*',
91-
'monitoring/bulk/20_privileges.yml': '*',
92-
'license/20_put_license.yml': '*',
93-
'snapshot/10_basic.yml': '*',
90+
'monitoring/bulk/10_basic.yml': ['*'],
91+
'monitoring/bulk/20_privileges.yml': ['*'],
92+
'license/20_put_license.yml': ['*'],
93+
'snapshot/10_basic.yml': ['*'],
9494
// the body is correct, but the regex is failing
95-
'sql/sql.yml': 'Getting textual representation',
95+
'sql/sql.yml': ['Getting textual representation'],
9696
// we are setting two certificates in the docker config
97-
'ssl/10_basic.yml': '*',
97+
'ssl/10_basic.yml': ['*'],
9898
// docker issue?
99-
'watcher/execute_watch/60_http_input.yml': '*',
99+
'watcher/execute_watch/60_http_input.yml': ['*'],
100100
// the checks are correct, but for some reason the test is failing on js side
101101
// I bet is because the backslashes in the rg
102-
'watcher/execute_watch/70_invalid.yml': '*',
103-
'watcher/put_watch/10_basic.yml': '*',
104-
'xpack/15_basic.yml': '*'
102+
'watcher/execute_watch/70_invalid.yml': ['*'],
103+
'watcher/put_watch/10_basic.yml': ['*'],
104+
'xpack/15_basic.yml': ['*']
105105
}
106106

107107
function Runner (opts) {
@@ -130,7 +130,7 @@ Runner.prototype.waitCluster = function (callback, times = 0) {
130130
this.client.cluster.health(
131131
{ waitForStatus: 'green', timeout: '50s' },
132132
(err, res) => {
133-
if (++times < 10) {
133+
if (err && ++times < 10) {
134134
setTimeout(() => {
135135
this.waitCluster(callback, times)
136136
}, 5000)
@@ -221,10 +221,13 @@ Runner.prototype.start = function (opts) {
221221
if (opts.isPlatinum) {
222222
const list = Object.keys(platinumBlackList)
223223
for (i = 0; i < list.length; i++) {
224-
if (file.endsWith(list[i]) && (name === platinumBlackList[list[i]] || platinumBlackList[list[i]] === '*')) {
225-
const testName = file.slice(file.indexOf(`${sep}elasticsearch${sep}`)) + ' / ' + name
226-
tap.skip(`Skipping test ${testName} because is blacklisted in the platinum test`)
227-
return
224+
const platTest = platinumBlackList[list[i]]
225+
for (var j = 0; j < platTest.length; j++) {
226+
if (file.endsWith(list[i]) && (name === platTest[j] || platTest[j] === '*')) {
227+
const testName = file.slice(file.indexOf(`${sep}elasticsearch${sep}`)) + ' / ' + name
228+
tap.skip(`Skipping test ${testName} because is blacklisted in the platinum test`)
229+
return
230+
}
228231
}
229232
}
230233
}

0 commit comments

Comments
 (0)