[API][Tests] Updates unit tests for API and perform_request_spec

Author: picandocodigo

elasticsearch-api/spec/unit/actions/clear_scroll_spec.rb

@@ -22,33 +22,15 @@
   let(:expected_args) do
     [
       'DELETE',
-      '_search/scroll/abc123',
+      '_search/scroll',
       {},
-      nil,
+      { scroll_id: 'abc123' },
       {},
-      { defined_params: { scroll_id: 'abc123' }, endpoint: 'clear_scroll' }
+      { endpoint: 'clear_scroll' }
     ]
   end
 
   it 'performs the request' do
-    expect(client_double.clear_scroll(scroll_id: 'abc123')).to be_a Elasticsearch::API::Response
-  end
-
-  context 'when a list of scroll ids is provided' do
-
-    let(:expected_args) do
-      [
-          'DELETE',
-          '_search/scroll/abc123,def456',
-          {},
-          nil,
-          {},
-          { defined_params: { scroll_id: ['abc123', 'def456'] }, endpoint: 'clear_scroll' }
-      ]
-    end
-
-    it 'performs the request' do
-      expect(client_double.clear_scroll(scroll_id: ['abc123', 'def456'])).to be_a Elasticsearch::API::Response
-    end
+    expect(client_double.clear_scroll(body: { scroll_id: 'abc123' })).to be_a Elasticsearch::API::Response
   end
 end

elasticsearch-api/spec/unit/actions/cluster/reroute_spec.rb

@@ -21,12 +21,12 @@
 
   let(:expected_args) do
     [
-        'POST',
-        '_cluster/reroute',
-        {},
-        {},
-        {},
-        { endpoint: 'cluster.reroute' }
+      'POST',
+      '_cluster/reroute',
+      {},
+      nil,
+      {},
+      { endpoint: 'cluster.reroute' }
     ]
   end
 
@@ -38,12 +38,12 @@
 
     let(:expected_args) do
       [
-          'POST',
-          '_cluster/reroute',
-          {},
-          { commands: [ move: { index: 'myindex', shard: 0 }] },
-          {},
-          { endpoint: 'cluster.reroute' }
+        'POST',
+        '_cluster/reroute',
+        {},
+        { commands: [ move: { index: 'myindex', shard: 0 }] },
+        {},
+        { endpoint: 'cluster.reroute' }
       ]
     end
 

elasticsearch-api/spec/unit/actions/indices/get_field_mapping_spec.rb

@@ -26,7 +26,7 @@
         {},
         nil,
         {},
-        { endpoint: 'indices.get_field_mapping' }
+        { endpoint: 'indices.get_field_mapping', defined_params: { fields: 'foo' } }
     ]
   end
 
@@ -35,11 +35,10 @@
   end
 
   it 'performs the request' do
-    expect(client_double.indices.get_field_mapping(field: 'foo')).to be_a Elasticsearch::API::Response
+    expect(client_double.indices.get_field_mapping(fields: 'foo')).to be_a Elasticsearch::API::Response
   end
 
   context 'when an index is specified' do
-
     let(:url) do
       'foo/_mapping/field/bam'
     end
@@ -51,12 +50,12 @@
         {},
         nil,
         {},
-        { defined_params: { index: 'foo' }, endpoint: 'indices.get_field_mapping' }
+        { defined_params: { index: 'foo', fields: 'bam' }, endpoint: 'indices.get_field_mapping' }
       ]
     end
 
     it 'performs the request' do
-      expect(client_double.indices.get_field_mapping(index: 'foo', field: 'bam')).to be_a Elasticsearch::API::Response
+      expect(client_double.indices.get_field_mapping(index: 'foo', fields: 'bam')).to be_a Elasticsearch::API::Response
     end
   end
 end

elasticsearch-api/spec/unit/actions/indices/resolve_cluster_spec.rb

@@ -30,19 +30,6 @@
     ]
   end
 
-  context 'when there is no name specified' do
-    let(:client) do
-      Class.new { include Elasticsearch::API }.new
-    end
-
-    it 'raises an exception' do
-      expect {
-        client.indices.resolve_cluster
-      }.to raise_exception(ArgumentError)
-    end
-  end
-
-
   context 'when name is specified' do
     it 'performs the request' do
       expect(client_double.indices.resolve_cluster(name: 'foo')).to be_a Elasticsearch::API::Response

elasticsearch-api/spec/unit/actions/inference/inference_spec.rb

@@ -21,16 +21,16 @@
   let(:expected_args) do
     [
       'PUT',
-      '_inference/foo/bar',
+      '_inference/bar',
       {},
-      nil,
       {},
-      { defined_params: { inference_id: 'bar', task_type: 'foo' },
+      {},
+      { defined_params: { inference_id: 'bar' },
         endpoint: 'inference.put' }
     ]
   end
 
   it 'performs the request' do
-    expect(client_double.inference.put(task_type: 'foo', inference_id: 'bar')).to be_a Elasticsearch::API::Response
+    expect(client_double.inference.put(body: {}, inference_id: 'bar')).to be_a Elasticsearch::API::Response
   end
 end

elasticsearch-api/spec/unit/actions/inference/put_spec.rb

@@ -23,14 +23,14 @@
       'PUT',
       '_inference/foo/bar/_update',
       {},
-      nil,
+      {},
       {},
       { defined_params: { inference_id: 'bar', task_type: 'foo' },
         endpoint: 'inference.update' }
     ]
   end
 
   it 'performs the request' do
-    expect(client_double.inference.update(task_type: 'foo', inference_id: 'bar')).to be_a Elasticsearch::API::Response
+    expect(client_double.inference.update(task_type: 'foo', body: {}, inference_id: 'bar')).to be_a Elasticsearch::API::Response
   end
 end

elasticsearch-api/spec/unit/actions/inference/stream_inference_spec.rb

@@ -22,7 +22,7 @@
     [
       'GET',
       '_ingest/ip_location/database/foo',
-      {},
+      { body: {}},
       nil,
       {},
       { defined_params: { id: 'foo' }, endpoint: 'ingest.get_ip_location_database' }

elasticsearch-api/spec/unit/actions/inference/unified_inference_spec.rb

@@ -21,7 +21,7 @@
   let(:expected_args) do
     [
       'POST',
-      '_ml/trained_models/foo/deployment/_infer',
+      '_ml/trained_models/foo/_infer',
       {},
       {},
       {},

elasticsearch-api/spec/unit/actions/inference/update_spec.rb

@@ -23,21 +23,28 @@
       'POST',
       'my-index/_mtermvectors',
       {},
-      body,
+      { ids: [1,2,3] },
       {},
       { defined_params: { index: 'my-index' }, endpoint: 'mtermvectors' }
     ]
   end
 
-  let(:body) do
-    { ids: [1, 2, 3] }
-  end
-
   it 'performs the request' do
     expect(client_double.mtermvectors(index: 'my-index', body: { ids: [1, 2, 3] })).to be_a Elasticsearch::API::Response
   end
 
   context 'when a list of ids is passed instead of a body' do
+    let(:expected_args) do
+      [
+        'GET',
+        'my-index/_mtermvectors',
+        {ids: '1,2,3'},
+        nil,
+        {},
+        { defined_params: { index: 'my-index' }, endpoint: 'mtermvectors' }
+      ]
+    end
+
     it 'performs the request' do
       expect(client_double.mtermvectors(index: 'my-index', ids: [1, 2, 3])).to be_a Elasticsearch::API::Response
     end

elasticsearch-api/spec/unit/actions/ingest/get_ip_location_database_spec.rb

@@ -22,11 +22,11 @@
     let(:expected_args) do
       [
         'GET',
-        '_search/scroll/cXVlcn...',
+        '_search/scroll',
         {},
         nil,
         {},
-        { defined_params: { scroll_id: 'cXVlcn...' }, endpoint: 'scroll' }
+        { endpoint: 'scroll' }
       ]
     end
 

elasticsearch-api/spec/unit/actions/machine_learning/infer_trained_model_deployment_spec.rb

@@ -23,7 +23,11 @@
 describe 'Perform request args' do
   Elasticsearch::API::FilesHelper.files.each do |filepath|
     spec = Elasticsearch::API::EndpointSpec.new(filepath)
-    next if spec.module_namespace.flatten.first == '_internal' || spec.visibility != 'public'
+    next if spec.module_namespace.flatten.first == '_internal' ||
+            spec.visibility != 'public' ||
+            # TODO: Once the test suite is migrated to elasticsearch-specification, these should be removed
+            spec.module_namespace.flatten.first == 'rollup' ||
+            ['scroll', 'clear_scroll', 'connector.last_sync'].include?(spec.endpoint_name)
 
     # These are the path parts defined by the user in the method argument
     defined_path_parts = spec.path_params.inject({}) do |params, part|
@@ -35,13 +39,11 @@
       params.merge(part.to_sym => 'testing')
     end
 
+    required_params.merge!(body: {}) if ['inference.put', 'inference.update', 'inference.chat_completion_unified'].include? spec.endpoint_name
+
     let(:client_double) do
       Class.new { include Elasticsearch::API }.new.tap do |client|
         expect(client).to receive(:perform_request) do |_, _, _, _, _, request_params|
-          # The create method ends up becoming an 'index' request
-          if expected_perform_request_params[:endpoint] == 'create'
-            expected_perform_request_params[:endpoint] = 'index'
-          end
           # Check that the expected hash is passed to the perform_request method
           expect(request_params).to eq(expected_perform_request_params)
         end.and_return(response_double)