[Gem] Styling, refactor for elasticsearch Gem

Author: picandocodigo

elasticsearch/Gemfile

@@ -30,6 +30,4 @@ if ENV['TRANSPORT_VERSION'] == 'main'
   gem 'elastic-transport', git: 'https://github.com/elastic/elastic-transport-ruby.git', branch: 'main'
 end
 
-if RUBY_VERSION >= '3.0'
-  gem 'opentelemetry-sdk', require: false
-end
+gem 'opentelemetry-sdk', require: false if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.0')

elasticsearch/elasticsearch.gemspec

@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'elasticsearch/version'
 
@@ -45,10 +45,9 @@ Gem::Specification.new do |s|
   s.extra_rdoc_files  = ['README.md', 'LICENSE.txt']
   s.rdoc_options      = ['--charset=UTF-8']
 
-  s.required_ruby_version = '>= 2.5'
-
-  s.add_dependency 'elastic-transport', '~> 8.3'
+  s.required_ruby_version = '>= 2.6' # For compatibility with JRuby 9.3
   s.add_dependency 'elasticsearch-api', '9.0.0'
+  s.add_dependency 'elastic-transport', '~> 8.3'
 
   s.add_development_dependency 'base64'
   s.add_development_dependency 'bundler'

elasticsearch/lib/elasticsearch.rb

@@ -37,8 +37,9 @@ class Client
     #
     # @param [Hash] arguments - initializer arguments
     # @option arguments [String] :cloud_id - The Cloud ID to connect to Elastic Cloud
-    # @option arguments [String, Hash] :api_key Use API Key Authentication, either the base64 encoding of `id` and `api_key`
-    #                                           joined by a colon as a String, or a hash with the `id` and `api_key` values.
+    # @option arguments [String, Hash] :api_key Use API Key Authentication, either the base64 encoding of `id` and
+    #                                           `api_key` joined by a colon as a String, or a hash with the `id` and
+    #                                           `api_key` values.
     # @option arguments [String] :opaque_id_prefix set a prefix for X-Opaque-Id when initializing the client.
     #                                              This will be prepended to the id you set before each request
     #                                              if you're using X-Opaque-Id
@@ -65,10 +66,10 @@ def method_missing(name, *args, &block)
           opaque_id = @opaque_id_prefix ? "#{@opaque_id_prefix}#{opaque_id}" : opaque_id
           args[4] = headers.merge('X-Opaque-Id' => opaque_id)
         end
-        unless @verified
-          verify_elasticsearch(*args, &block)
-        else
+        if @verified
           @transport.perform_request(*args, &block)
+        else
+          verify_elasticsearch(*args, &block)
         end
       else
         @transport.send(name, *args, &block)
@@ -101,6 +102,7 @@ def verify_elasticsearch(*args, &block)
         raise e
       end
       raise Elasticsearch::UnsupportedProductError unless response.headers['x-elastic-product'] == 'Elasticsearch'
+
       @verified = true
       response
     end
@@ -175,7 +177,7 @@ def set_user_agent!(arguments)
       end
       arguments[:transport_options] ||= {}
       arguments[:transport_options][:headers] ||= {}
-      arguments[:transport_options][:headers].merge!({ user_agent: user_agent.join('; ')})
+      arguments[:transport_options][:headers].merge!({ user_agent: user_agent.join('; ') })
     end
   end