Skip to content

Add missing conf. catalog-info #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Add missing conf. catalog-info #19

merged 1 commit into from
Oct 20, 2023

Conversation

verofa
Copy link
Contributor

@verofa verofa commented Oct 20, 2023

The build_branches and build_tags attributes must to be specify under the provider_settings config.
https://github.com/elastic/ci/blob/main/terrazzo/terrazzo/config/defaults/buildkite/pipelines.py

Otherwise, Backstage/Terrazzo do not recognise them and catalog-info.yaml turn out to be an invalid configuration file, so Terrazzo will try to delete the resources it contains: https://buildkite.com/elastic/terrazzo/builds/27884#018b4aa9-6d58-4176-9311-2fc443d2ee83/6-5848

@verofa verofa requested review from JoshMock and a team October 20, 2023 01:35
@verofa
Copy link
Contributor Author

verofa commented Oct 20, 2023

I am pretty sure everyone in your time zone is not available now, since all the check have passed and with this being a small change, I will admin-merge and observe to unblock Terrazzo.

@verofa verofa merged commit 4f14372 into main Oct 20, 2023
@verofa verofa deleted the add-provider-settings branch October 20, 2023 01:43
@verofa verofa self-assigned this Oct 20, 2023
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Thanks for catching this @verofa! 🖤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants