Support both host and hosts

But only one host in hosts list

Author: JoshMock

elasticsearch_serverless/_async/client/__init__.py

@@ -121,6 +121,7 @@ class AsyncElasticsearch(BaseClient):
     def __init__(
         self,
         host: t.Optional[_TYPE_HOST] = None,
+        hosts: t.Optional[t.List[_TYPE_HOST]] = None,
         *,
         # API
         cloud_id: t.Optional[str] = None,
@@ -166,6 +167,14 @@ def __init__(
         # Internal use only
         _transport: t.Optional[AsyncTransport] = None,
     ) -> None:
+        if host is not None and hosts is not None:
+            raise ValueError("Can't specify both 'host' and 'hosts'")
+
+        if hosts is not None:
+            if len(hosts) > 1:
+                raise ValueError("Can't specify more than one host in 'hosts'")
+            host = hosts[0]
+
         if host is None and cloud_id is None and _transport is None:
             raise ValueError("Either 'host' or 'cloud_id' must be specified")
 

elasticsearch_serverless/_sync/client/__init__.py

@@ -121,6 +121,7 @@ class Elasticsearch(BaseClient):
     def __init__(
         self,
         host: t.Optional[_TYPE_HOST] = None,
+        hosts: t.Optional[t.List[_TYPE_HOST]] = None,
         *,
         # API
         cloud_id: t.Optional[str] = None,
@@ -166,6 +167,14 @@ def __init__(
         # Internal use only
         _transport: t.Optional[Transport] = None,
     ) -> None:
+        if host is not None and hosts is not None:
+            raise ValueError("Can't specify both 'host' and 'hosts'")
+
+        if hosts is not None:
+            if len(hosts) > 1:
+                raise ValueError("Can't specify more than one host in 'hosts'")
+            host = hosts[0]
+
         if host is None and cloud_id is None and _transport is None:
             raise ValueError("Either 'host' or 'cloud_id' must be specified")
 

test_elasticsearch_serverless/test_client/test_options.py

@@ -469,3 +469,19 @@ def test_options_timeout_parameters(self):
             "retry_on_status": (404,),
             "retry_on_timeout": True,
         }
+
+    def test_host_vs_hosts(self):
+        with pytest.raises(ValueError) as e:
+            Elasticsearch(
+                host="http://localhost:9200",
+                hosts=["http://localhost:9200", "http://localhost:9201"],
+                transport_class=DummyTransport,
+            )
+        assert str(e.value) == "Can't specify both 'host' and 'hosts'"
+
+        with pytest.raises(ValueError) as e:
+            Elasticsearch(
+                hosts=["http://localhost:9200", "http://localhost:9201"],
+                transport_class=DummyTransport,
+            )
+        assert str(e.value) == "Can't specify more than one host in 'hosts'"