Skip to content

Commit a8636b3

Browse files
authored
Stop reading client tests using GitHub token (#50)
1 parent b817bf5 commit a8636b3

File tree

2 files changed

+1
-20
lines changed

2 files changed

+1
-20
lines changed

.buildkite/run-tests

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,10 @@ docker build \
6161

6262
echo -e "--- :docker: :python: Run integration tests for Python $PYTHON_VERSION"
6363

64-
GITHUB_TOKEN=$(vault read -field=token secret/ci/elastic-elasticsearch-serverless-python/github-token)
65-
export GITHUB_TOKEN
66-
6764
docker run \
6865
-e ELASTICSEARCH_URL \
6966
-e "ES_API_KEY=$ES_API_SECRET_KEY" \
7067
-e PYTHON_CONNECTION_CLASS \
71-
-e GITHUB_TOKEN \
7268
-e AIOHTTP_NO_EXTENSIONS \
7369
-e FROZENLIST_NO_EXTENSIONS \
7470
-e YARL_NO_EXTENSIONS \

test_elasticsearch_serverless/test_server/test_rest_api_spec.py

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -532,10 +532,6 @@ def remove_implicit_resolver(cls, tag_to_remove):
532532

533533
# Try loading the REST API test specs from the Elastic Artifacts API
534534
try:
535-
github_token = os.environ.get("GITHUB_TOKEN")
536-
if github_token is None:
537-
raise RuntimeError("GITHUB_TOKEN environment variable is not set")
538-
539535
# Construct the HTTP and Elasticsearch client
540536
http = urllib3.PoolManager(retries=10)
541537
client = Elasticsearch(es_url(), api_key=es_api_key(), request_timeout=3)
@@ -545,18 +541,7 @@ def remove_implicit_resolver(cls, tag_to_remove):
545541
)
546542

547543
# Download the zip and start reading YAML from the files in memory
548-
package_zip = zipfile.ZipFile(
549-
io.BytesIO(
550-
http.request(
551-
"GET",
552-
yaml_tests_url,
553-
headers={
554-
"Authorization": f"Bearer {github_token}",
555-
"Accept": "application/vnd.github+json",
556-
},
557-
).data
558-
)
559-
)
544+
package_zip = zipfile.ZipFile(io.BytesIO(http.request("GET", yaml_tests_url).data))
560545

561546
for yaml_file in package_zip.namelist():
562547
if not re.match(r"^.*\/tests\/.*\.ya?ml$", yaml_file):

0 commit comments

Comments
 (0)