Pass endpoint_id and path_parts to BaseClient #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2024
miguelgrinberg
previously approved these changes
Jun 24, 2024
pquentin
dismissed
miguelgrinberg’s stale review
The merge-base changed after approval.
|
git got confused by the squash which caused merged conflicts, but I confirmed this is OK by regenerating everything. |
miguelgrinberg
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #52
This backports elastic/elasticsearch-py#2457. However, to make the tests pass with the current transport, this also includes the typing changes of elastic/elasticsearch-py#2482 and does not send those parameters to the transport in preparation of backporting elastic/elasticsearch-py#2490. (Turns out knowing the future allows avoiding failed experiments!)
This depends on #66 and #67 that I would like to merge first to make this pull request smaller. And this unblocks #68.