Skip to content

Commit 06e9e23

Browse files
authored
Ts generator: Fix array and unions usage (#381)
* Fix array and unions usage * Updated output
1 parent 346b5f8 commit 06e9e23

File tree

2 files changed

+17
-15
lines changed

2 files changed

+17
-15
lines changed

output/typescript/types.ts

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ export interface AsyncSearchSubmitAsyncSearchSubmitRequest extends RequestBase {
562562
typed_keys?: boolean
563563
version?: boolean
564564
wait_for_completion_timeout?: Time
565-
fields?: Field | DateField[]
565+
fields?: (Field | DateField)[]
566566
}
567567
}
568568

@@ -818,7 +818,7 @@ export interface BulkBulkRequest<TSource = unknown> extends RequestBase {
818818
timeout?: Time
819819
wait_for_active_shards?: WaitForActiveShards
820820
require_alias?: boolean
821-
body: BulkBulkOperationContainer | TSource[]
821+
body: (BulkBulkOperationContainer | TSource)[]
822822
}
823823

824824
export interface BulkBulkResponse extends ResponseBase {
@@ -2652,9 +2652,9 @@ export interface CatCatTransformsCatTransformsRequest extends CatCatRequestBase
26522652
export type CatCatTransformsCatTransformsResponse = CatCatTransformsCatTransformsRecord[]
26532653

26542654
export interface MlInfoCategorizationAnalyzer {
2655-
filter?: string | AnalysisTokenFiltersTokenFilter[]
2655+
filter?: (string | AnalysisTokenFiltersTokenFilter)[]
26562656
tokenizer?: string | AnalysisTokenizersTokenizer
2657-
char_filter?: string | AnalysisCharFiltersCharFilter[]
2657+
char_filter?: (string | AnalysisCharFiltersCharFilter)[]
26582658
}
26592659

26602660
export interface MlCategoryDefinition {
@@ -4606,7 +4606,7 @@ export interface EqlSearchEqlSearchRequest extends RequestBase {
46064606
keep_on_completion?: boolean
46074607
wait_for_completion_timeout?: Time
46084608
size?: uint | float
4609-
fields?: Field | EqlSearchEqlSearchFieldFormatted[]
4609+
fields?: (Field | EqlSearchEqlSearchFieldFormatted)[]
46104610
result_position?: EqlSearchEqlResultPosition
46114611
}
46124612
}
@@ -6445,10 +6445,10 @@ export interface IndicesAnalyzeIndicesAnalyzeRequest extends RequestBase {
64456445
body?: {
64466446
analyzer?: string
64476447
attributes?: string[]
6448-
char_filter?: string | AnalysisCharFiltersCharFilter[]
6448+
char_filter?: (string | AnalysisCharFiltersCharFilter)[]
64496449
explain?: boolean
64506450
field?: Field
6451-
filter?: string | AnalysisTokenFiltersTokenFilter[]
6451+
filter?: (string | AnalysisTokenFiltersTokenFilter)[]
64526452
normalizer?: string
64536453
text?: IndicesAnalyzeTextToAnalyze
64546454
tokenizer?: string | AnalysisTokenizersTokenizer
@@ -9023,12 +9023,12 @@ export interface MsearchMultiSearchRequest extends RequestBase {
90239023
search_type?: SearchType
90249024
rest_total_hits_as_int?: boolean
90259025
typed_keys?: boolean
9026-
body: MsearchMultiSearchHeader | MsearchMultiSearchBody[]
9026+
body: (MsearchMultiSearchHeader | MsearchMultiSearchBody)[]
90279027
}
90289028

90299029
export interface MsearchMultiSearchResponse<TDocument = unknown> extends ResponseBase {
90309030
took: long
9031-
responses: MsearchMultiSearchResult<TDocument> | ErrorResponse[]
9031+
responses: (MsearchMultiSearchResult<TDocument> | ErrorResponse)[]
90329032
}
90339033

90349034
export interface MsearchMultiSearchResult<TDocument = unknown> extends SearchSearchResponse<TDocument> {
@@ -11312,19 +11312,19 @@ export interface SearchSearchRequest extends RequestBase {
1131211312
highlight?: SearchHighlightingHighlight
1131311313
track_total_hits?: boolean | integer
1131411314
indices_boost?: Record<IndexName, double>[]
11315-
docvalue_fields?: SearchSourceFilteringDocValueField | Field | SearchSourceFilteringDocValueField[]
11315+
docvalue_fields?: SearchSourceFilteringDocValueField | (Field | SearchSourceFilteringDocValueField)[]
1131611316
min_score?: double
1131711317
post_filter?: QueryDslAbstractionsContainerQueryContainer
1131811318
profile?: boolean
1131911319
query?: QueryDslAbstractionsContainerQueryContainer
1132011320
rescore?: SearchRescoringRescore | SearchRescoringRescore[]
1132111321
script_fields?: Record<string, ScriptField>
11322-
search_after?: integer | string[]
11322+
search_after?: (integer | string)[]
1132311323
size?: integer
1132411324
slice?: SlicedScroll
1132511325
sort?: SearchSortSort
1132611326
_source?: boolean | Fields | SearchSourceFilteringSourceFilter
11327-
fields?: Field | DateField[]
11327+
fields?: (Field | DateField)[]
1132811328
suggest?: SearchSuggestersSuggestContainer | Record<string, SearchSuggestersSuggestContainer>
1132911329
terminate_after?: long
1133011330
timeout?: string
@@ -12700,7 +12700,7 @@ export interface IngestProcessorsSortProcessor extends IngestProcessorBase {
1270012700
target_field: Field
1270112701
}
1270212702

12703-
export type SearchSortSortResults = long | double | string | null[]
12703+
export type SearchSortSortResults = (long | double | string | null)[]
1270412704

1270512705
export interface ExistsSourceSourceExistsRequest extends RequestBase {
1270612706
id: Id
@@ -13503,7 +13503,7 @@ export interface AggregationsMetricTopHitsTopHitsAggregation extends Aggregation
1350313503
}
1350413504

1350513505
export interface AggregationsTopMetrics {
13506-
sort: long | double | string[]
13506+
sort: (long | double | string)[]
1350713507
metrics: Record<string, long | double | string>
1350813508
}
1350913509

typescript-generator/index.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,9 @@ function buildValue (type: M.ValueOf, openGenerics?: string[]): string | number
8989
}
9090
return `${createName(type.type)}${buildGenerics(type.generics, openGenerics)}`
9191
case 'array_of':
92-
return `${buildValue(type.value, openGenerics)}[]`
92+
return type.value.kind === 'union_of'
93+
? `(${buildValue(type.value, openGenerics)})[]`
94+
: `${buildValue(type.value, openGenerics)}[]`
9395
case 'union_of':
9496
return type.items.map(t => buildValue(t, openGenerics)).join(' | ')
9597
case 'dictionary_of':

0 commit comments

Comments
 (0)