Skip to content

Commit 0c4848b

Browse files
committed
Address review comments
1 parent ebd6572 commit 0c4848b

File tree

4 files changed

+21
-83
lines changed

4 files changed

+21
-83
lines changed

output/schema/schema.json

Lines changed: 13 additions & 72 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

output/typescript/types.ts

Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

specification/_global/search/_types/hits.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,11 @@ import { Sort, SortResults } from '@_types/sort'
3939

4040
export class Hit<TDocument> {
4141
_index: IndexName
42-
_id?: Id
42+
/**
43+
* @es_quirk '_id' is not available when using 'stored_fields: _none_'
44+
* on a search request. Otherwise the field is always present on hits.
45+
*/
46+
_id: Id
4347
_score?: double | null
4448
_explanation?: Explanation
4549
fields?: Dictionary<string, UserDefinedValue>

specification/_types/sort.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,7 @@ export type SortCombinations = Field | SortOptions
9898

9999
export type Sort = SortCombinations | SortCombinations[]
100100

101-
/**
102-
* Only used when sorting by "_tsid"
103-
*/
104-
export type SortTsid = Dictionary<Field, FieldValue>
105-
106-
export type SortResults = Array<long | double | string | null | SortTsid>
101+
export type SortResults = FieldValue[]
107102

108103
/**
109104
* Defines what values to pick in the case a document contains multiple values for a particular field.

0 commit comments

Comments
 (0)