Skip to content

Commit 0f35a3b

Browse files
committed
Add changes from review
1 parent ebd6572 commit 0f35a3b

File tree

5 files changed

+48
-83
lines changed

5 files changed

+48
-83
lines changed

output/schema/schema.json

Lines changed: 13 additions & 72 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

output/typescript/types.ts

Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

specification/_global/search/_types/hits.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,11 @@ import { Sort, SortResults } from '@_types/sort'
3939

4040
export class Hit<TDocument> {
4141
_index: IndexName
42-
_id?: Id
42+
/**
43+
* @es_quirk '_id' is not available when using 'stored_fields: _none_'
44+
* on a search request. Otherwise the field is always present on hits.
45+
*/
46+
_id: Id
4347
_score?: double | null
4448
_explanation?: Explanation
4549
fields?: Dictionary<string, UserDefinedValue>
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
/*
2+
* Licensed to Elasticsearch B.V. under one or more contributor
3+
* license agreements. See the NOTICE file distributed with
4+
* this work for additional information regarding copyright
5+
* ownership. Elasticsearch B.V. licenses this file to you under
6+
* the Apache License, Version 2.0 (the "License"); you may
7+
* not use this file except in compliance with the License.
8+
* You may obtain a copy of the License at
9+
*
10+
* http://www.apache.org/licenses/LICENSE-2.0
11+
*
12+
* Unless required by applicable law or agreed to in writing,
13+
* software distributed under the License is distributed on an
14+
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15+
* KIND, either express or implied. See the License for the
16+
* specific language governing permissions and limitations
17+
* under the License.
18+
*/
19+
20+
/**
21+
* Union of two responses depending on input parameters
22+
* and whether or not the server-side action completes
23+
* before sending a response. Without setting any parameters
24+
* that start with 'wait_for_*' the 'Complete' response is
25+
* always returned.
26+
*/
27+
export type WaitForCompletion<Complete, Incomplete> = Complete | Incomplete

specification/_types/sort.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,7 @@ export type SortCombinations = Field | SortOptions
9898

9999
export type Sort = SortCombinations | SortCombinations[]
100100

101-
/**
102-
* Only used when sorting by "_tsid"
103-
*/
104-
export type SortTsid = Dictionary<Field, FieldValue>
105-
106-
export type SortResults = Array<long | double | string | null | SortTsid>
101+
export type SortResults = FieldValue[]
107102

108103
/**
109104
* Defines what values to pick in the case a document contains multiple values for a particular field.

0 commit comments

Comments
 (0)