Skip to content

Commit 9117d36

Browse files
miguelgrinberglcawl
andcommitted
add example requests for endpoints that do not use bodies (#4489)
* add a few example requests for endpoints that do not use bodies * Remove x-codeSamples from overlay * restructure existing examples w/o bodies as request examples * skip examples w/o bodies when generating openapi examples * add a lot of missing examples * remove duplicate test * more examples missed in previous commit --------- Co-authored-by: lcawl <[email protected]>
1 parent 0d7d745 commit 9117d36

File tree

584 files changed

+6432
-1222
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

584 files changed

+6432
-1222
lines changed

compiler-rs/clients_schema_to_openapi/src/paths.rs

Lines changed: 10 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -148,14 +148,16 @@ pub fn add_endpoint(
148148
// }
149149
};
150150

151-
let openapi_example = Example {
152-
value: example,
153-
description: schema_example.description.clone(),
154-
summary: schema_example.summary.clone(),
155-
external_value: None,
156-
extensions: Default::default(),
157-
};
158-
openapi_examples.insert(name.clone(), ReferenceOr::Item(openapi_example));
151+
if example.is_some() {
152+
let openapi_example = Example {
153+
value: example,
154+
description: schema_example.description.clone(),
155+
summary: schema_example.summary.clone(),
156+
external_value: None,
157+
extensions: Default::default(),
158+
};
159+
openapi_examples.insert(name.clone(), ReferenceOr::Item(openapi_example));
160+
}
159161
}
160162
openapi_examples
161163
}
@@ -358,21 +360,6 @@ pub fn add_endpoint(
358360
}
359361
}
360362
}
361-
if code_samples.is_empty() {
362-
// if there are no example requests we look for example responses
363-
// this can only happen for examples that do not have a request body
364-
if let Some(examples) = response_def.examples.clone() {
365-
if let Some((_, example)) = examples.first() {
366-
let request_line = example.method_request.clone().unwrap_or(String::from(""));
367-
if !request_line.is_empty() {
368-
code_samples.push(serde_json::json!({
369-
"lang": "Console",
370-
"source": request_line + "\n",
371-
}));
372-
}
373-
}
374-
}
375-
}
376363
if !code_samples.is_empty() {
377364
extensions.insert("x-codeSamples".to_string(), serde_json::json!(code_samples));
378365
}
Binary file not shown.

docs/overlays/elasticsearch-shared-overlays.yaml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1084,17 +1084,6 @@ actions:
10841084
# update:
10851085
# aggregations:
10861086
# x-model: true
1087-
# Examples
1088-
## xCodeSamples
1089-
- target: "$.paths['/{index}/_doc/{id}']['head']"
1090-
description: "Add xCodeSamples for check document operation"
1091-
update:
1092-
x-codeSamples:
1093-
- $ref: "../../specification/_global/exists/examples/xCodeSamples/DocumentExistsConsoleExample1.yaml"
1094-
- $ref: "../../specification/_global/exists/examples/xCodeSamples/DocumentExistsCurlExample1.yaml"
1095-
- $ref: "../../specification/_global/exists/examples/xCodeSamples/DocumentExistsJavaScriptExample1.yaml"
1096-
- $ref: "../../specification/_global/exists/examples/xCodeSamples/DocumentExistsPythonExample1.yaml"
1097-
- $ref: "../../specification/_global/exists/examples/xCodeSamples/DocumentExistsRubyExample1.yaml"
10981087
# Remove long lists of enum values
10991088
- target: "$.components['schemas']['cat._types.CatAnomalyDetectorColumn'].enum"
11001089
description: Remove enum array

0 commit comments

Comments
 (0)