Skip to content

Commit d13d488

Browse files
[Backport 7.x] Fix stubbed rollup API (#631)
Co-authored-by: Steve Gordon <[email protected]>
1 parent b274563 commit d13d488

File tree

5 files changed

+30
-62
lines changed

5 files changed

+30
-62
lines changed

output/schema/schema.json

Lines changed: 18 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -9204,7 +9204,7 @@
92049204
"namespace": "rollup.rollup"
92059205
},
92069206
"since": "7.13.0",
9207-
"stability": "TODO",
9207+
"stability": "experimental",
92089208
"urls": [
92099209
{
92109210
"methods": [
@@ -124037,20 +124037,10 @@
124037124037
"CommonQueryParameters"
124038124038
],
124039124039
"body": {
124040-
"kind": "properties",
124041-
"properties": [
124042-
{
124043-
"name": "stub",
124044-
"required": true,
124045-
"type": {
124046-
"kind": "instance_of",
124047-
"type": {
124048-
"name": "integer",
124049-
"namespace": "_types"
124050-
}
124051-
}
124052-
}
124053-
]
124040+
"kind": "value",
124041+
"value": {
124042+
"kind": "user_defined_value"
124043+
}
124054124044
},
124055124045
"inherits": {
124056124046
"type": {
@@ -124065,47 +124055,38 @@
124065124055
},
124066124056
"path": [
124067124057
{
124068-
"name": "stubb",
124058+
"description": "The index to roll up",
124059+
"name": "index",
124069124060
"required": true,
124070124061
"type": {
124071124062
"kind": "instance_of",
124072124063
"type": {
124073-
"name": "integer",
124064+
"name": "IndexName",
124074124065
"namespace": "_types"
124075124066
}
124076124067
}
124077-
}
124078-
],
124079-
"query": [
124068+
},
124080124069
{
124081-
"name": "stuba",
124070+
"description": "The name of the rollup index to create",
124071+
"name": "rollup_index",
124082124072
"required": true,
124083124073
"type": {
124084124074
"kind": "instance_of",
124085124075
"type": {
124086-
"name": "integer",
124076+
"name": "IndexName",
124087124077
"namespace": "_types"
124088124078
}
124089124079
}
124090124080
}
124091-
]
124081+
],
124082+
"query": []
124092124083
},
124093124084
{
124094124085
"body": {
124095-
"kind": "properties",
124096-
"properties": [
124097-
{
124098-
"name": "stub",
124099-
"required": true,
124100-
"type": {
124101-
"kind": "instance_of",
124102-
"type": {
124103-
"name": "integer",
124104-
"namespace": "_types"
124105-
}
124106-
}
124107-
}
124108-
]
124086+
"kind": "value",
124087+
"value": {
124088+
"kind": "user_defined_value"
124089+
}
124109124090
},
124110124091
"kind": "response",
124111124092
"name": {

output/schema/validation-errors.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1351,12 +1351,6 @@
13511351
],
13521352
"response": []
13531353
},
1354-
"rollup.rollup": {
1355-
"request": [
1356-
"Endpoint has \"@stability: TODO"
1357-
],
1358-
"response": []
1359-
},
13601354
"rollup.start_job": {
13611355
"request": [
13621356
"Endpoint has \"@stability: TODO"

output/typescript/types.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12773,16 +12773,12 @@ export interface RollupPutJobResponse extends AcknowledgedResponseBase {
1277312773
}
1277412774

1277512775
export interface RollupRollupRequest extends RequestBase {
12776-
stubb: integer
12777-
stuba: integer
12778-
body?: {
12779-
stub: integer
12780-
}
12776+
index: IndexName
12777+
rollup_index: IndexName
12778+
body?: any
1278112779
}
1278212780

12783-
export interface RollupRollupResponse {
12784-
stub: integer
12785-
}
12781+
export type RollupRollupResponse = any
1278612782

1278712783
export interface RollupRollupSearchRequest extends RequestBase {
1278812784
index: Indices

specification/rollup/rollup/RollupRequest.ts

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,19 @@
1717
* under the License.
1818
*/
1919

20+
import { UserDefinedValue } from '@spec_utils/UserDefinedValue'
2021
import { RequestBase } from '@_types/Base'
21-
import { integer } from '@_types/Numeric'
22+
import { IndexName } from '@_types/common'
2223

2324
/**
2425
* @rest_spec_name rollup.rollup
2526
* @since 7.13.0
26-
* @stability TODO
27+
* @stability experimental
2728
*/
2829
export interface Request extends RequestBase {
2930
path_parts?: {
30-
stubb: integer
31-
}
32-
query_parameters?: {
33-
stuba: integer
34-
}
35-
body?: {
36-
stub: integer
31+
index: IndexName
32+
rollup_index: IndexName
3733
}
34+
body?: UserDefinedValue // TODO: This API is experimental and no docs exist describing it. Requires reverse engineering if made stable
3835
}

specification/rollup/rollup/RollupResponse.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
* under the License.
1818
*/
1919

20-
import { integer } from '@_types/Numeric'
20+
import { UserDefinedValue } from '@spec_utils/UserDefinedValue'
2121

2222
export class Response {
23-
body: { stub: integer }
23+
body: UserDefinedValue // TODO: This API is experimental and no docs exist describing it. Requires reverse engineering if made stable
2424
}

0 commit comments

Comments
 (0)