Skip to content

Fix Open Point in time API #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix Open Point in time API #2829

merged 1 commit into from
Sep 5, 2024

Conversation

pquentin
Copy link
Member

The remaining failures will be fixed when the point in time NEST tests will be removed.

This comment was marked as outdated.

body: { id: Id }
body: {
/** Shards used to create the PIT */
_shards: ShardStatistics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_shards is optional

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Transport API changes now have a transport version which is used for serverless deployments. It's not really optional, and will be mandatory in stack 8.16. That said, we could wait for this pull request to land in Serverless before merging.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could merge this in main and wait for the backport?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we won't backport because 8.15 will never have _shards. (I could backport the index_filter part but I'm being lazy here.)

We agreed offline to wait for the _shards change to land in serverless before merging.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
open_point_in_time 🟢 7/7 7/7

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit de646de into main Sep 5, 2024
6 checks passed
@pquentin pquentin deleted the fix-open-pit-api branch September 5, 2024 11:22
@pquentin pquentin mentioned this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants