Skip to content

Fix Open Point in time API #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix Open Point in time API #2829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions output/openapi/elasticsearch-openapi.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions output/openapi/elasticsearch-serverless-openapi.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 29 additions & 3 deletions output/schema/schema-serverless.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 29 additions & 3 deletions output/schema/schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions output/typescript/types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions specification/_global/open_point_in_time/OpenPointInTimeRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import { RequestBase } from '@_types/Base'
import { ExpandWildcards, Indices, Routing } from '@_types/common'
import { Duration } from '@_types/Time'
import { QueryContainer } from '@_types/query_dsl/abstractions'

/**
* A search request by default executes against the most recent visible data of the target indices,
Expand Down Expand Up @@ -65,4 +66,10 @@ export interface Request extends RequestBase {
*/
expand_wildcards?: ExpandWildcards
}
body: {
/**
* Allows to filter indices if the provided query rewrites to `match_none` on every shard.
*/
index_filter?: QueryContainer
}
}
7 changes: 6 additions & 1 deletion specification/_global/open_point_in_time/OpenPointInTimeResponse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,12 @@
*/

import { Id } from '@_types/common'
import { ShardStatistics } from '@_types/Stats'

export class Response {
body: { id: Id }
body: {
/** Shards used to create the PIT */
_shards: ShardStatistics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_shards is optional

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Transport API changes now have a transport version which is used for serverless deployments. It's not really optional, and will be mandatory in stack 8.16. That said, we could wait for this pull request to land in Serverless before merging.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could merge this in main and wait for the backport?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we won't backport because 8.15 will never have _shards. (I could backport the index_filter part but I'm being lazy here.)

We agreed offline to wait for the _shards change to land in serverless before merging.

id: Id
}
}
Loading