Skip to content

[DOCS] Fix monitoring operation summary and visibility #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 12, 2024

Relates to #3226, #3300

This PR edits the monitoring API summaries (https://www.elastic.co/docs/api/doc/elasticsearch/group/endpoint-monitoring) and copies the "visibility=private" from the JSON spec so that it can be properly excluded from the OpenAPI document.

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
monitoring.bulk 🟢 6/6 6/6

You can validate this API yourself by using the make validate target.

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit 7cf7656 into main Dec 17, 2024
11 checks passed
@lcawl lcawl deleted the monitor-summaries branch December 17, 2024 01:00
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
lcawl added a commit that referenced this pull request Dec 17, 2024
lcawl added a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants