Skip to content

Add indices.disk_usage Enpoint #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2021
Merged

Add indices.disk_usage Enpoint #700

merged 3 commits into from
Sep 8, 2021

Conversation

philkra
Copy link
Contributor

@philkra philkra commented Sep 7, 2021

added the request but I need some help from @delvedor & @swallez how to model the reponse.

@philkra philkra requested review from delvedor and swallez September 7, 2021 15:53
@philkra philkra added the on hold label Sep 7, 2021
delvedor
delvedor reviewed Sep 8, 2021
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given it's still an experimental API, I would define the entire response as UserDefinedValue and revisit later, similar to what we did in #630.

@philkra philkra requested a review from delvedor September 8, 2021 09:00
@philkra
Copy link
Contributor Author

philkra commented Sep 8, 2021

adjusted to @delvedor #700 (review)

@delvedor delvedor removed the on hold label Sep 8, 2021
@delvedor delvedor merged commit 959202b into main Sep 8, 2021
@delvedor delvedor deleted the patch-014 branch September 8, 2021 09:01
github-actions bot pushed a commit that referenced this pull request Sep 8, 2021
@philkra @github-actions
Add indices.disk_usage Enpoint (#700)
18252ce
@github-actions github-actions bot mentioned this pull request Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

@swallez swallez Awaiting requested review from swallez

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philkra @delvedor